Improve Cloud Provider disk quota cost estimates

[jvlcek]

This issue was initiated from Pull Request discussion: https://github.com/ManageIQ/manageiq/pull/4347

Need to understand how to Improve disk Openstack quota cost estimates

[jvlcek]

Proposed DB column name for flavor Disk Information by Cloud Provider (Azure uses the term to Series for Flavor)

MiQ DB column	Amazon	OpenStack	Azure
root_disk_size	NA	disk	OS disk
swap_disk_size	NA	swap	swap
ephemeral_disk_size	instance_store_size	ephemeral	NA
ephemeral_disk_count	instance_store_volumes	1 if ephemeral > 0	NA

[matthewd]

@jvlcek ephemeral_disk_size and ephemeral_disk_count

[jvlcek]

Thank you @matthewd. I changed root_disk and swap_disk to also include the _size postfix.

[Fryguy]

:+1:

[blomquisg]

@jvlcek, @matthewd, and @Fryguy, thanks for getting to the bottom of this!!

[jvlcek]

@miq-bot assign @jvlcek

[jvlcek]

Setting ephemeral_disk_count to 1 if OS disk > 0 for Azure seems a little awkward since Azure does not have ephemeral_disk_size. @matthewd, @Fryguy @bdunne @blomquisg, thoughts?

[bdunne]

Does Azure have ephemeral disks? If not, then I would set :ephemeral_disk_size => nil, :ephemeral_disk_count => 0

[jvlcek]

@bdunne That feels correct to me. Updating table to reflect that chance. Thank you.