ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 898 forks source link

Non-English locale text has broken title text #7917

Closed jameswnl closed 8 years ago

jameswnl commented 8 years ago

As shown below screen shot 2016-04-12 at 6 35 34 pm

jameswnl commented 8 years ago

The {:tables=>"Vm Infras"} is not right.

Fryguy commented 8 years ago

@mzazrivec Please review

mzazrivec commented 8 years ago

@miq-bot assign mzazrivec

mzazrivec commented 8 years ago

What's happening here is that there are strings like these in the Japanese catalog:

#, fuzzy
msgid "Provision %{tables}"
msgstr "%s のプロビジョニング "

#, fuzzy
msgid "Set Ownership for %{table}"
msgstr "%s の所有権の設定"

#, fuzzy
msgid "%{table} Policy Simulation"
msgstr "%s ポリシーシミュレーション"

#, fuzzy
msgid "%{table} Policy Assignment"
msgstr "%s ポリシーの割り当て"

Note the %{table} -> %s discrepancy (that's what will mess up the string in the UI.

This mess is all done automatically by gettext:find rake task and there's no easy way to fix this really.

What I'm proposing to fix this issue:

  1. remove all non-english catalogs from our git
  2. have a mechanism (a rake task for example) to download the catalogs from zanata when needed (for development / testing / appliance building) purposes.

Not having the catalogs in our git would mean:

  1. less stuff in our git
  2. less confusion when doing git grep ...
  3. faster appliance start

@Fryguy thoughts?