search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.34k stars 896 forks source link

Refresh replication set tables on advanced configuration save #8190

Closed carbonin closed 8 years ago

carbonin commented 8 years ago

The pglogical replication set is not currently updated when the excludes in the advanced config editor are changed.

This can be checked by changing the tables and comparing the new config excludes with the tables listed by MiqPglogical.new.included_tables you will see that they will have some tables in common (which should never happen).

@Fryguy I'm not sure where to put this logic. I don't really want to do this unconditionally, but the only place we seem to know what key is being changed is after we have computed the diffs here and that doesn't feel right at all. Any suggestions?

carbonin commented 8 years ago

As of now if a user wants to change the excluded tables they must do so before they designate the database as a replication remote type or they must run MiqPglogical.new.refresh_excludes in the rails console after making the change.

carbonin commented 8 years ago

@miq-bot assign @carbonin @miq-bot add_label replication, bug

Fryguy commented 8 years ago

You might be able to leverage the VMDB::Config::Activator