search

ManageIQ / miq_bot

ManageIQ Bot
Apache License 2.0
15 stars 39 forks source link

Add ability for robocop commenter to ignore certain changes #35

Open bdunne opened 9 years ago

bdunne commented 9 years ago

Use case: I am renaming a large old file (shows up as an add and delete in git) without changing any of the content. Rubocop comments on the PR with 400+ issues in the old file.

It would be nice to be able to add [no complaints] to the commit message and have rubocop ignore those changes in its comment.

abellotti commented 9 years ago

the problem with the [no complaints] is the possibility of it being abused over time and the code's look will deviate. Is there a way for the bot to detect that it was only a file name change and automatically skip the rubocop checks ?

Fryguy commented 9 years ago

I'd have to look at how git is presenting the renaming...I believe it's an Add and Delete, but there may be a way to show the renames.

Fryguy commented 9 years ago

I think the no-complaints is a cool idea...might be better to allow it to be more surgical. I'm thinking something like

[no_complaints vmdb/app/models/whatever.rb]

Fryguy commented 9 years ago

on the naming of this option, I wonder if we can ride some of the namings that rubocop uses: https://github.com/bbatsov/rubocop#disabling-cops-within-source-code

miq-bot commented 4 years ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.