Add a check that the release version matches the deployment yml

ManageIQ / miq_bot

ManageIQ Bot

Apache License 2.0

15 stars 39 forks source link

Add a check that the release version matches the deployment yml #681

Closed Fryguy closed 1 month ago

Fryguy commented 2 months ago

@bdunne Please review. I verified this as I released v0.20.4 and it did what was expected. Technically this also fixes a bug where the docker build looked at the tip of the branch instead of the tag.

miq-bot commented 2 months ago

Some comments on commit https://github.com/Fryguy/miq_bot/commit/1470b7bed12d94e8a12cbb9ccac21043427c8c0e

lib/tasks/production.rake

[ ] :warning: - 125 - Detected puts. Remove all debugging statements.
[ ] :warning: - 127 - Detected puts. Remove all debugging statements.

miq-bot commented 2 months ago

Checked commit https://github.com/Fryguy/miq_bot/commit/1470b7bed12d94e8a12cbb9ccac21043427c8c0e with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cake: