Move activesupport hack to Gemfile

ManageIQ / more_core_extensions

MoreCoreExtensions are a set of core extensions beyond those provided by ActiveSupport.

MIT License

5 stars 23 forks source link

Move activesupport hack to Gemfile #29

Closed bdunne closed 8 years ago

bdunne commented 8 years ago

Prevents limitation from showing up in the gemspec Provides the proper requirement based on the ruby version in use

Fryguy commented 8 years ago

This won't work on deployed gems...only locally. That is, the Gemfile is only used for development, whereas the gemspec is what's used in production/deployment.

bdunne commented 8 years ago

@Fryguy Maybe we can investigate tomorrow? I was testing yesterday and it worked fine for me, maybe I missed a test case.

bdunne commented 8 years ago

:turtle:

miq-bot commented 8 years ago

Checked commit https://github.com/bdunne/more_core_extensions/commit/44109d806267d2cbf20e8df5929ed41dfaf3fbc0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 1 file checked, 0 offenses detected Everything looks good. :+1: