Allow for > 6 chars TLDs in email addresses

[imtayadeway]

As per RFC 1035

Addresses https://github.com/ManageIQ/manageiq/issues/12781

Thanks @Fryguy for the suggestion on this one. In the above issue you mentioned that we could also go further and use the regex outlined in http://www.regular-expressions.info/email.html. I do think that's a good idea and would like to do that, but am thinking I might do that in a follow up PR as it breaks some existing tests. I don't think that's a problem, but I'm being extra cautious - it should at least be easier to revert if it breaks anyone's workflow and keep this enhancement.

Also, TIL a new word: prestidigitation :grin:

@miq-bot add-label enhacement @miq-bot assign @Fryguy

[miq-bot]

@imtayadeway Cannot apply the following label because they are not recognized: enhacement

[miq-bot]

Checked commit https://github.com/imtayadeway/more_core_extensions/commit/79e089fa08a654dab7a6c045030e1433c8cb6610 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 2 files checked, 4 offenses detected

lib/more_core_extensions/core_ext/string/formats.rb

• [ ] :exclamation: - Line 4, Col 26 - Style/SpecialGlobalVars - Prefer $OUTPUT_RECORD_SEPARATOR or $ORS from the stdlib 'English' module over $\.
• [ ] :exclamation: - Line 4, Col 26 - Style/VariableInterpolation - Replace interpolated variable $\ with expression #{$\}.
• [ ] :exclamation: - Line 4, Col 57 - Style/SpecialGlobalVars - Prefer $OUTPUT_RECORD_SEPARATOR or $ORS from the stdlib 'English' module over $\.
• [ ] :exclamation: - Line 4, Col 57 - Style/VariableInterpolation - Replace interpolated variable $\ with expression #{$\}.

[Fryguy]

The Hakiri thing is independent of this PR, so I'm ignoring that.