search

ManageIQ / more_core_extensions

MoreCoreExtensions are a set of core extensions beyond those provided by ActiveSupport.
MIT License
5 stars 23 forks source link

Update email regex #33

Closed imtayadeway closed 7 years ago

imtayadeway commented 7 years ago

Updates the email regex to use that defined in http://www.regular-expressions.info/email.html. The main reason to do this is because it is more permissive, and email regexes in general tend to be overly constrictive. Sure enough, this breaks some of the existing tests which asserted that certain combinations of characters were invalid. Importantly, though, no assertions on valid emails were broken (though the tests here aren't exhaustive, so pinch of salt).

Follow up to https://github.com/ManageIQ/manageiq/issues/12781

@Fryguy (assuming this is OK) do we need a version bump before and after this?

Fryguy commented 7 years ago

do we need a version bump before and after this?

I can bump the version right now.