Extract Benchmark.realtime_store/block from manageiq-gems-pending

[Fryguy]

@bdunne @jrafanie Please review.

Note a change from the original [ref] ...previously this registered a logger and logged exceptions. Instead, at the library level it makes more sense to me that the caller handle the logging. So as not to lose the timings, however, we can modify the exception to add the timing metadata to it.

[miq-bot]

Checked commits https://github.com/Fryguy/more_core_extensions/compare/3329d734eaeb7282ae65eb211c88f946d6bc9347~...f4eee52773a5b3c2566a6cae954ff0d04c23d7de with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 4 files checked, 6 offenses detected

lib/more_core_extensions/core_ext/benchmark/realtime_store.rb

• [ ] :exclamation: - Line 103, Col 5 - Style/ClassVars - Replace class var @@realtime_by_tid with a class instance var.
• [ ] :exclamation: - Line 18, Col 17 - Rails/TimeZone - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.
• [ ] :exclamation: - Line 22, Col 19 - Rails/TimeZone - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.

spec/core_ext/benchmark/realtime_store_spec.rb

• [ ] :warning: - Line 93, Col 7 - Lint/RescueException - Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
• [ ] :exclamation: - Line 124, Col 7 - Style/MultilineBlockChain - Avoid multi-line chains of blocks.
• [ ] :exclamation: - Line 77, Col 5 - Style/MultilineBlockChain - Avoid multi-line chains of blocks.

[Fryguy]

As a follow up, I think we should replace the class variable with some thread local variable and/or thread_mattr_accessor