search

ManageIQ / more_core_extensions

MoreCoreExtensions are a set of core extensions beyond those provided by ActiveSupport.
MIT License
5 stars 23 forks source link

Extract method stable_sort_by #67

Closed lpichler closed 5 years ago

lpichler commented 5 years ago

extraction method stable_sort_by from Ruport::Data::Table

Usage: we need to reach same report sorting to get report results in API https://github.com/ManageIQ/manageiq-api/pull/547

@miq-bot add_label refactoring, reporting

Links

removal from core: https://github.com/ManageIQ/manageiq/pull/18389

@miq-bot assign @bdunne

miq-bot commented 5 years ago

@lpichler Cannot apply the following labels because they are not recognized: refactoring, reporting

Fryguy commented 5 years ago

Not a fan of this commit because it does more than stable sorting. It also introduces case insensitive sorting, and weird boolean sorting (weird in that false < true < nil - or read differently falsey < truthy < falsey o_O)

Fryguy commented 5 years ago

IMO, this should have been named something else because it does so many things at once. Not sure what a better name is...perhaps tabular_sort?

lpichler commented 5 years ago

Not a fan of this commit because it does more than stable sorting. It also introduces case insensitive sorting, and weird boolean sorting (weird in that false < true < nil - or read differently falsey < truthy < falsey o_O)

it was taken as it is from core repo - I'm trying to avoid big steps, I can look why we have this specialties and how it affects report results.

IMO, this should have been named something else because it does so many things at once. Not sure what a better name is...perhaps tabular_sort?

Ok, sure I can change it.

thanks