search

ManageIQ / more_core_extensions

MoreCoreExtensions are a set of core extensions beyond those provided by ActiveSupport.
MIT License
5 stars 23 forks source link

Updated documentation and changelog #72

Closed Fryguy closed 4 years ago

Fryguy commented 4 years ago

@bdunne Please review.

I was about to release this as 4.0.0, but wanted your opinion first on the breaking change.

I can release as is, or alternately what I can do is create an Enumerable#stable_sort_by method that is deprecated and just calls Array#tabular_sort . This way we could release a 3.8.0 to bring in the other changes, and then after release a 4.0.0 with the breaking change. WDYT?

miq-bot commented 4 years ago

Checked commit https://github.com/Fryguy/more_core_extensions/commit/f8580e9f9d264b0f9dc8f00da9b551cad20e838f with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 1 file checked, 0 offenses detected Everything looks fine. :trophy:

bdunne commented 4 years ago

Probably a good idea to release v3.8.0 first

Fryguy commented 4 years ago

Closing now that we released 3.8.0 and it went out as part of that release instead.

miq-bot commented 4 years ago

This pull request is not mergeable. Please rebase and repush.