remove deprecated ruby versions

ManageIQ / more_core_extensions

MoreCoreExtensions are a set of core extensions beyond those provided by ActiveSupport.

MIT License

5 stars 23 forks source link

remove deprecated ruby versions #86

Closed kbrock closed 4 years ago

kbrock commented 4 years ago

Per ruby-lang 2.4 is completely unsupported, and 2.5.x only gets security fixes. I am suggesting dropping these to use fewer cycles in PRs. But there may be other reasons to support older versions of ruby.

This also upgrades the travis build environment to the latest.

miq-bot commented 4 years ago

Checked commit https://github.com/kbrock/more_core_extensions/commit/9563da8045c1d26efb83be69d52d08ad46c15a84 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 1 file checked, 1 offense detected

[ ] :bomb: :boom: :fire: :fire_engine: - Linter/Yaml - missing config files

Fryguy commented 4 years ago

I'm not sure on this...it doesn't hurt that it works on old versions. We definitely should remove 2.6.0 from the fail-fast list though, and add 2.7. @bdunne?

bdunne commented 4 years ago

I'm indifferent. I don't think there are enough PRs to this repo that it causes a problem to run a few extra jobs.

Fryguy commented 4 years ago

@kbrock let's just keep the old versions, but the rest of the changes are good. To simplify, for the old versions, can you just list as major.minor (e.g. for "2.1.10", instead we can just have "2.1") ?

Fryguy commented 4 years ago

I'm actually leaning towards merging this... but I don't know if it affects semver

miq-bot commented 4 years ago

This pull request is not mergeable. Please rebase and repush.

Fryguy commented 4 years ago

Closed in favor of #90