remove color from length count

[d-m-u]

It'd be cool if the length calculation here didn't include color codes.

also it's something that if it were right I expect Keenan might back

[Fryguy]

Can you show a before/after? I can't really understand what the issue was (i.e was the column too long or too short).

[d-m-u]

hey @Fryguy and @kbrock, thanks for the review on this, could I please ask you to take another look?

[bdunne]

Do we want to remove the color completely, or just for the field length?

[d-m-u]

it was only line 121, until the comment yesterday

and when I asked about it again, here's what I got:

Jul 07 17:31
that method totally looks right though

[kbrock]

thanks. this looks nice @d-m-u

work for you @Fryguy ?

[Fryguy]

@d-m-u Accidental close?

[d-m-u]

@Fryguy no, we're going to implement it in benchmark-sweet and not rely on this dependency.

[Fryguy]

ok...I still like the feature, so I'll probably reopen at some point.

[Fryguy]

Updated with the code snippet from https://github.com/ManageIQ/more_core_extensions/pull/87#discussion_r455286172 and added a bunch more tests for the edge cases.

@bdunne Please review.

[bdunne]

@Fryguy Can you add a test with multiple colors?

[Fryguy]

Updated with a better algorithm that determines matching escape sequences that fall into the expected width. Still need to add the specs.

[miq-bot]

Checked commits https://github.com/d-m-u/more_core_extensions/compare/e1ff5e04700bd530af177be648d617ff3a99166f~...4df5c3e26e7d03f2758cb10b592db2be97d79fbc with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 2 files checked, 24 offenses detected

spec/core_ext/array/tableize_spec.rb

• [ ] :exclamation: - Line 106, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 110, Col 1 - Layout/ClosingHeredocIndentation - EOF is not aligned with expected = <<-EOF.
• [ ] :exclamation: - Line 110, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 117, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 121, Col 1 - Layout/ClosingHeredocIndentation - EOF is not aligned with expected = <<-EOF.
• [ ] :exclamation: - Line 121, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 128, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 132, Col 1 - Layout/ClosingHeredocIndentation - EOF is not aligned with expected = <<-EOF.
• [ ] :exclamation: - Line 132, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 18, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 22, Col 1 - Layout/ClosingHeredocIndentation - EOF is not aligned with expected = <<-EOF.
• [ ] :exclamation: - Line 22, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 29, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 33, Col 1 - Layout/ClosingHeredocIndentation - EOF is not aligned with expected = <<-EOF.
• [ ] :exclamation: - Line 33, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 62, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 66, Col 1 - Layout/ClosingHeredocIndentation - EOF is not aligned with expected = <<-EOF.
• [ ] :exclamation: - Line 66, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 84, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 88, Col 1 - Layout/ClosingHeredocIndentation - EOF is not aligned with expected = <<-EOF.
• [ ] :exclamation: - Line 88, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 95, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 99, Col 1 - Layout/ClosingHeredocIndentation - EOF is not aligned with expected = <<-EOF.
• [ ] :exclamation: - Line 99, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.