Delay the pkgwat exception via Component.verify.

ManageIQ / polisher

Polisher is a Ruby module and set of utilities aimed to assisting the post-publishing packaging process for Ruby gems and applications.

MIT License

14 stars 14 forks source link

Delay the pkgwat exception via Component.verify. #102

Closed jrafanie closed 10 years ago

jrafanie commented 10 years ago

Tested this in combination with #101 and confirmed the LoadError is no longer raised and is instead delayed until you try to use the corresponding classes, see below:

$ bundle console
Resolving dependencies...
Failed to require gem2rpm.  Added runtime exception in Polisher::RPM::Requirement
Failed to require gem2rpm.  Added runtime exception in Polisher::RPM::Spec
Failed to require pkgwat.  Added runtime exception in Polisher::Bodhi
Failed to require pkgwat.  Added runtime exception in Polisher::RHN
Failed to require pkgwat.  Added runtime exception in Polisher::Fedora
irb(main):001:0> Polisher::Bodhi.new
RuntimeError: polisher is missing a dependency - cannot instantiate

Note, this branch is independent of #101 and can be merged independently.

jrafanie commented 10 years ago

@movitto @brandondunne @Fryguy Please review, note... I'm not changing style in this pull request.

coveralls commented 10 years ago

Coverage increased (+0.07%) when pulling 74171efbf844acef0e8a179fe3c1cf3ca14d7caf on jrafanie:relax_pkgwat_dependency_via_component_verify into 19b894b90f6277d8c6f2e50b1758aac86685378b on ManageIQ:master.

movitto commented 10 years ago

@jrafanie looks good, tried it out locally. Once we get the others sorted out will merge

coveralls commented 10 years ago

Coverage increased (+0.15%) when pulling f5652d3500fdf8dd901e449caa5920a7ba15f217 on jrafanie:relax_pkgwat_dependency_via_component_verify into 19b894b90f6277d8c6f2e50b1758aac86685378b on ManageIQ:master.

movitto commented 10 years ago

@jrafanie not quite sure this isn't saying there is a conflict since 938bacc9 is already merged. But since that's there, mind dropping that patch from this PR (better safe than sorry :-) ). Thx.

jrafanie commented 10 years ago

@movitto git should just work as is with that commit but yeah, easy enough to remove that commit and rebase the merged #101. Should be ready to merge... just waiting on travis.

miq-bot commented 10 years ago

Checked commit https://github.com/jrafanie/polisher/commit/b1cf0e9db3d949667cd645eb6c66054f76868b09 with rubocop 0.21.0 2 files checked, 4 offenses detected

lib/polisher/bodhi.rb

[x] Style - Line 15, Col 71 - DotPosition - Place the . on the next line, together with the method name.
[x] Style - Line 16, Col 78 - DotPosition - Place the . on the next line, together with the method name.
[x] Style - Line 18, Col 41 - SpaceAfterControlKeyword - Use space after control keywords.

lib/polisher/rhn.rb

[x] Warn - Line 10, Col 28 - UnusedMethodArgument - Unused method argument - name. If it's necessary, use _ or _name as an argument name to indicate that it won't be used. You can also write as version_for(*) if you want the method to accept any arguments but don't care about them.

coveralls commented 10 years ago

Coverage remained the same when pulling b1cf0e9db3d949667cd645eb6c66054f76868b09 on jrafanie:relax_pkgwat_dependency_via_component_verify into e4bde8bd666c2338610d785a3871eb7d2afbcbc2 on ManageIQ:master.