Missing deps - Githubissues

ManageIQ / polisher

Polisher is a Ruby module and set of utilities aimed to assisting the post-publishing packaging process for Ruby gems and applications.

MIT License

14 stars 14 forks source link

Missing deps #104

Closed movitto closed 10 years ago

movitto commented 10 years ago

Implements feature to be used in builder as discussed

coveralls commented 10 years ago

Coverage increased (+3.49%) when pulling c545437026aa1235c4ab929cd940c0aecfd7041e on movitto:missing-deps into 3bd13a6c5939faa2199270f7c09a60f39c8d16b9 on ManageIQ:master.

miq-bot commented 10 years ago

Checked commits https://github.com/movitto/polisher-1/commit/4452a41222576ad229b8789b6f56d083fd250f0b .. https://github.com/movitto/polisher-1/commit/5da7f3e23f42aa3fc72fde65b61a9b7f06a76e4a with rubocop 0.21.0 3 files checked, 1 offense detected

spec/version_checker_spec.rb

[ ] Warn - Line 283, Col 44 - Void - Operator == used in void context.

coveralls commented 10 years ago

Coverage increased (+3.49%) when pulling 5da7f3e23f42aa3fc72fde65b61a9b7f06a76e4a on movitto:missing-deps into 32ee2f32b9d0e7e4f6e34083dfa3ed1d5e1e9aa5 on ManageIQ:master.

jrafanie commented 10 years ago

@movitto I haven't had a chance to look at this yet. Thanks for tackling it.

I believe this address #103, if so, can you provide output against fedora koji similar to what I did the in the issue?

In other words, a "before" and "after"?

Thanks!

miq-bot commented 10 years ago

This pull request is not mergeable. Please rebase and repush.

movitto commented 10 years ago

Split into #120 #121 and #122 as discussed. Closing.