[polisher/fedora] Fetch user packages from pkdb api.

ManageIQ / polisher

Polisher is a Ruby module and set of utilities aimed to assisting the post-publishing packaging process for Ruby gems and applications.

MIT License

14 stars 14 forks source link

[polisher/fedora] Fetch user packages from pkdb api. #112

Closed axilleas closed 10 years ago

axilleas commented 10 years ago

For starters, the previous PACKAGE_LIST was not working since pkgdb2 is using new uris, hence the method was broken. Then I thought since there is an API, why not use it?

So, gems_owned_by(user) now fetches a user's packages, both owned and co-maintained. If you wish to fetch only the ones a packager owns, I can simply remove the second query.

As for the tests, this method had no tests to begin with, but I'm not so familiar with rspec to test api queries. If anyone can point me how to test this, I'll happily implement it.

coveralls commented 10 years ago

Coverage decreased (-0.07%) when pulling b4ce08abf8bf6ed9fa15126bb3afe47cbca43967 on axilleas:polisher_fedora into a50f53d62117c80c39b7fe9bc212fa0337527da2 on ManageIQ:master.

miq-bot commented 10 years ago

Checked commit https://github.com/axilleas/polisher/commit/b4ce08abf8bf6ed9fa15126bb3afe47cbca43967 with rubocop 0.21.0 1 file checked, 0 offenses detected Everything looks good. :star:

movitto commented 10 years ago

@axilleas @jrafanie gave this a quick run over and it works well. Agree w/ style / refactoring suggestions.

Since this isn't currently a big use case for cloudforms will merge in so as not to hold Axilleas up, but lets revisit some of these refactoring tasks in a future style / cleanup PR.