Compare Gem::Version objects to be sure of the highest version

ManageIQ / polisher

Polisher is a Ruby module and set of utilities aimed to assisting the post-publishing packaging process for Ruby gems and applications.

MIT License

14 stars 14 forks source link

Compare Gem::Version objects to be sure of the highest version #118

Closed strzibny closed 10 years ago

strzibny commented 10 years ago

My fix for the upstream highest version doesn't work everytime as we have to compare objects of Gem::Version to be sure. This PR makes it right.

This fixes #ec9a7e5

coveralls commented 10 years ago

Coverage remained the same when pulling dc991f6f83da1a692168c3f06e170afd6026def0 on strzibny:fix-max into 48990f5eac37d28c2dfb5da59297fae9181d4a05 on ManageIQ:master.

strzibny commented 10 years ago

I rebased it to require 'rubygems/version'.

miq-bot commented 10 years ago

Checked commit https://github.com/strzibny/polisher/commit/e1365a91b2db84f4dbad22f4ef5e29a8b8797a93 with rubocop 0.21.0 2 files checked, 2 offenses detected

lib/polisher/gem.rb

[ ] Style - Line 140, Col 35 - CollectionMethods - Prefer collect over map.
[ ] Style - Line 140, Col 38 - SpaceBeforeBlockBraces - Space missing to the left of {.

coveralls commented 10 years ago

Coverage remained the same when pulling e1365a91b2db84f4dbad22f4ef5e29a8b8797a93 on strzibny:fix-max into 48990f5eac37d28c2dfb5da59297fae9181d4a05 on ManageIQ:master.

movitto commented 10 years ago

@strzibny looks good, merging. Will incorporate the style feedback into a consolidated style PR in the near future (long time on backburner).

@jrafanie what rubocop config is being used for this? How is it being run?

jrafanie commented 10 years ago

@movitto The bot runs rubocop against the PR changed files, using https://github.com/ManageIQ/guides/blob/master/.rubocop.yml (I believe), and filters out lines that weren't changed in the PR.