Version checker fixes + specs

ManageIQ / polisher

Polisher is a Ruby module and set of utilities aimed to assisting the post-publishing packaging process for Ruby gems and applications.

MIT License

14 stars 14 forks source link

Version checker fixes + specs #120

Closed movitto closed 9 years ago

coveralls commented 10 years ago

Coverage increased (+3.15%) when pulling 22e0d5dd01c2bf103ac2d37f85fc6700b640328e on movitto:version_checker_fixes into 44186483b21ff6572529622243a11af764f04da9 on ManageIQ:master.

jrafanie commented 10 years ago

@movitto These look like good fixes, it's just difficult to review as "other edge case fixes" in a single commit. Commits are free and most of these fixes look worthy of their own commit and explanation.

movitto commented 10 years ago

@jrafanie split into smaller patches

coveralls commented 10 years ago

Coverage increased (+3.15%) when pulling 12c53d8dbb904d0ef6af6cb97ced46a61d50e2e4 on movitto:version_checker_fixes into 44186483b21ff6572529622243a11af764f04da9 on ManageIQ:master.

miq-bot commented 10 years ago

This pull request is not mergeable. Please rebase and repush.

jrafanie commented 10 years ago

@movitto Looks better. Please rebase now that #121 was merged.

miq-bot commented 10 years ago

Checked commits https://github.com/movitto/polisher-1/commit/2922976a4410ff5726f570c73a49605d5b2baf0c .. https://github.com/movitto/polisher-1/commit/ed40ff1043552964dc03d6025e21ff9646242d48 with rubocop 0.21.0 5 files checked, 0 offenses detected Everything looks good. :cookie:

coveralls commented 10 years ago

Coverage increased (+3.11%) when pulling ed40ff1043552964dc03d6025e21ff9646242d48 on movitto:version_checker_fixes into eb3e288e1bdc93d77f49677c248d6097c69858c0 on ManageIQ:master.

jrafanie commented 9 years ago

Closing as stale, we can re-open if this becomes active again.