Implement VersionChecker#versions_for and #version_of methods

ManageIQ / polisher

Polisher is a Ruby module and set of utilities aimed to assisting the post-publishing packaging process for Ruby gems and applications.

MIT License

14 stars 14 forks source link

Implement VersionChecker#versions_for and #version_of methods #122

Closed movitto closed 9 years ago

movitto commented 10 years ago

Summary: As a packager, I would like a high-level / single-value snapshot of package versions in multiple targets & subtargets

Background: Polisher can query multiple targets (git, koji, yum, other) as well as subtargets (git branches, koji tags, yum repos, etc) in a single call returning metadata such as package versions for each.

Inorder to facilitate metadata abstraction (which by nature is lossy but compact) we introduce a few methods that select the versions most frequent found in the polisher query targets and subtargets

Implementation: Adds to methods to VersionChecker:

versions_for: returns the most frequently referenced version in each configured polisher target (across all subtargets)
versions_of: returns the most frequently referenced version across all configured polisher targets

Includes specs for updated / new features.

movitto commented 10 years ago

@jrafanie @brandondunne @jvlcek use case attached

miq-bot commented 10 years ago

Checked commit https://github.com/movitto/polisher-1/commit/201b8918907aca6e33ffd4e4c21e15ad4d4965a4 with rubocop 0.21.0 2 files checked, 0 offenses detected Everything looks good. :star:

coveralls commented 10 years ago

Coverage increased (+0.11%) when pulling 201b8918907aca6e33ffd4e4c21e15ad4d4965a4 on movitto:frequent_versions into 44186483b21ff6572529622243a11af764f04da9 on ManageIQ:master.

jrafanie commented 10 years ago

@movitto Thanks for extracting this out and clarifying the use case.

If I understand correctly, this is providing the mode breakdown by target (git, koji, yum, etc.) or an aggregate mode across all targets.

@strzibny @axilleas @brandondunne @Fryguy @jvlcek, what are your thoughts on this PR?

Perhaps we can rename the methods to clarify the meaning more... VersionChecker already has version in the name so perhaps we can remove that redundancy. Perhaps something like VersionChecker#mode_per_target and VersionChecker#mode_all_targets... Naming is hard but I'd go for anything similar to "mode" and doesn't include "version".

Fryguy commented 10 years ago

I still don't get what is being solved here... It wasn't resolved / made clear in the other PR either... https://github.com/ManageIQ/polisher/pull/104/files#r15236255

Do you have a specific bug you are trying to solve? Can you give a real world example showing a "bad" case and how this fixes it to make it "good"? I think that demonstration would make it clear.
Why is most relevant being defined as the mode (i.e. most frequent). I would think greatest common factor would be a lot more accurate (and how bundler and other things work).

Fryguy commented 10 years ago

Also, what does this mean? Inorder to facilitate metadata abstraction (which by nature is lossy but compact)

jrafanie commented 9 years ago

Closing as stale, we can re-open if this becomes active again.