Genericize Version Checker Modules

ManageIQ / polisher

Polisher is a Ruby module and set of utilities aimed to assisting the post-publishing packaging process for Ruby gems and applications.

MIT License

14 stars 14 forks source link

Genericize Version Checker Modules #126

Closed movitto closed 9 years ago

movitto commented 9 years ago

Based on #125, this genericizes version checker modules such that they are automatically loaded from the polisher/adaptors/version_checker dir

coveralls commented 9 years ago

Coverage increased (+1.44%) when pulling b870b456c96d92334af3723378a04622f95f4f1a on movitto:checker_modules into 2a0c00ae6760cf7a9de1f3c2ff49676f3afb9b93 on ManageIQ:master.

movitto commented 9 years ago

@jrafanie there are a few ways it could be done, in the current case the version checker modules are mixed into the version checker class and just invoked as local methods in the VersionChecker class methods, no extra object instantiations are needed.

We could have a base version checker mixin and include that in each version checker class. But currently the only common method is 'default' so just going the simpler route should suffice for the time being.

miq-bot commented 9 years ago

Checked commit https://github.com/movitto/polisher-1/commit/e62e66116aa240624cbeaf1463c8855244d88b01 with rubocop 0.27.1 9 files checked, 3 offenses detected

lib/polisher/adaptors/checker_loader.rb

[ ] Style - Line 19, Col 23 - Style/MultilineOperationIndentation - Align the operands of an expression in an assignment spanning multiple lines.
[ ] Style - Line 54, Col 5 - Style/Alias - Use alias_method instead of alias.
[ ] Style - Line 58, Col 7 - Style/SymbolProc - Pass &:default? as an argument to select instead of a block.

coveralls commented 9 years ago

Coverage increased (+0.98%) when pulling e62e66116aa240624cbeaf1463c8855244d88b01 on movitto:checker_modules into 77f94a05d0924b64843bc9236a02a6363db32eaf on ManageIQ:master.

movitto commented 9 years ago

@jrafanie mergeable? (+ others?)