Expand Tests

[movitto]

Based on #127, continues expanding test suite, flushing out specs for gem, git, gemfile modules

[coveralls]

Coverage increased (+2.31%) when pulling bc5414f449eff4e1a16b6104de1122b827ccc900 on movitto:tests2 into 2a0c00ae6760cf7a9de1f3c2ff49676f3afb9b93 on ManageIQ:master.

[miq-bot]

Checked commits https://github.com/movitto/polisher-1/commit/501d0852209b135394443f4a26ff449ee86a8f54 .. https://github.com/movitto/polisher-1/commit/6bdccb4b1c9a011d242e33b7fbbe4ea4af7ff27d with rubocop 0.27.1 43 files checked, 120 offenses detected

lib/polisher/util/conf_helpers.rb

• [ ] Style - Line 49, Col 30 - Style/SpaceAroundEqualsInParameterDefault - Surrounding space missing in default value assignment.

spec/gem/attributes_spec.rb

• [ ] Style - Line 13, Col 22 - Style/MultilineOperationIndentation - Use 2 (not 13) spaces for indenting an expression spanning multiple lines.

spec/gem/diff_spec.rb

• [ ] Style - Line 70, Col 44 - Style/DotPosition - Place the . on the next line, together with the method name.

spec/gem/files_spec.rb

• [ ] Warn - Line 133, Col 23 - Lint/AmbiguousOperator - Ambiguous block operator. Parenthesize the method arguments if it's surely a block operator, or add a whitespace to the right of the & if it should be a binary AND.
• [ ] Warn - Line 159, Col 23 - Lint/AmbiguousOperator - Ambiguous block operator. Parenthesize the method arguments if it's surely a block operator, or add a whitespace to the right of the & if it should be a binary AND.
• [ ] Style - Line 76, Col 20 - Style/MultilineOperationIndentation - Use 2 (not 9) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 77, Col 20 - Style/MultilineOperationIndentation - Use 2 (not 9) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 90, Col 20 - Style/MultilineOperationIndentation - Use 2 (not 9) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 91, Col 20 - Style/MultilineOperationIndentation - Use 2 (not 9) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 105, Col 25 - Style/MultilineOperationIndentation - Use 2 (not 16) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 106, Col 25 - Style/MultilineOperationIndentation - Use 2 (not 16) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 150, Col 17 - Style/MultilineOperationIndentation - Use 2 (not 8) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 151, Col 17 - Style/MultilineOperationIndentation - Use 2 (not 8) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 152, Col 17 - Style/MultilineOperationIndentation - Use 2 (not 8) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 153, Col 17 - Style/MultilineOperationIndentation - Use 2 (not 8) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 154, Col 17 - Style/MultilineOperationIndentation - Use 2 (not 8) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 155, Col 18 - Style/SpaceBeforeBlockBraces - Space missing to the left of {.

spec/gem/retriever_spec.rb

• [ ] Style - Line 14, Col 40 - Style/MultilineOperationIndentation - Use 2 (not 29) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 23, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 35, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 39, Col 17 - Style/MultilineOperationIndentation - Use 2 (not 8) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 47, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 57, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 58, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 65, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 68, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 69, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 86, Col 27 - Style/MultilineOperationIndentation - Use 2 (not 18) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 87, Col 27 - Style/MultilineOperationIndentation - Use 2 (not 18) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 88, Col 27 - Style/MultilineOperationIndentation - Use 2 (not 18) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 111, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 119, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.

spec/gem/versions_spec.rb

• [ ] Style - Line 38, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 43, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 52, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 53, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 62, Col 33 - Style/MultilineOperationIndentation - Use 2 (not 24) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 63, Col 33 - Style/MultilineOperationIndentation - Use 2 (not 24) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 72, Col 35 - Style/MultilineOperationIndentation - Use 2 (not 24) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 77, Col 14 - Style/MultilineOperationIndentation - Use 2 (not 3) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 78, Col 14 - Style/MultilineOperationIndentation - Use 2 (not 3) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 80, Col 14 - Style/MultilineOperationIndentation - Use 2 (not 3) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 88, Col 37 - Style/MultilineOperationIndentation - Use 2 (not 24) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 93, Col 16 - Style/MultilineOperationIndentation - Use 2 (not 3) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 95, Col 16 - Style/MultilineOperationIndentation - Use 2 (not 3) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 97, Col 16 - Style/MultilineOperationIndentation - Use 2 (not 3) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 99, Col 16 - Style/MultilineOperationIndentation - Use 2 (not 3) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 102, Col 16 - Style/MultilineOperationIndentation - Use 2 (not 3) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 113, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 124, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 136, Col 26 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 141, Col 35 - Style/MultilineOperationIndentation - Use 2 (not 24) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 142, Col 35 - Style/MultilineOperationIndentation - Use 2 (not 24) spaces for indenting an expression spanning multiple lines.

spec/gemfile/deps_spec.rb

• [ ] Style - Line 12, Col 36 - Style/WordArray - Use %w or %W for array of words.

spec/gemfile/parser_spec.rb

• [ ] Style - Line 22, Col 9 - Style/LeadingCommentSpace - Missing space after #.

spec/git/pkg/attributes_spec.rb

• [ ] Style - Line 52, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 53, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 55, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 56, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 57, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 63, Col 28 - Style/MultilineOperationIndentation - Use 2 (not 19) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 64, Col 28 - Style/MultilineOperationIndentation - Use 2 (not 19) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 65, Col 28 - Style/MultilineOperationIndentation - Use 2 (not 19) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 74, Col 30 - Style/MultilineOperationIndentation - Use 2 (not 19) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 75, Col 30 - Style/MultilineOperationIndentation - Use 2 (not 19) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 76, Col 30 - Style/MultilineOperationIndentation - Use 2 (not 19) spaces for indenting an expression spanning multiple lines.

spec/git/pkg/builder_spec.rb

• [ ] Style - Line 21, Col 21 - Style/MultilineOperationIndentation - Use 2 (not 12) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 22, Col 21 - Style/MultilineOperationIndentation - Use 2 (not 12) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 38, Col 23 - Style/MultilineOperationIndentation - Use 2 (not 12) spaces for indenting an expression spanning multiple lines.

spec/git/pkg/repo_spec.rb

• [ ] Style - Line 34, Col 1 - Style/EmptyLines - Extra blank line detected.
• [ ] Style - Line 70, Col 11 - Style/Lambda - Use the new lambda literal syntax ->(params) {...}.
• [ ] Style - Line 70, Col 17 - Style/SpaceBeforeBlockBraces - Space missing to the left of {.
• [ ] Style - Line 108, Col 35 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 131, Col 21 - Style/MultilineOperationIndentation - Use 2 (not 12) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 141, Col 21 - Style/MultilineOperationIndentation - Use 2 (not 12) spaces for indenting an expression spanning multiple lines.

spec/git/pkg/versions_spec.rb

• [ ] Style - Line 13, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 14, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.

spec/rpm/requirement/attributes_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/requirement/comparison_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.
• [ ] Style - Line 93, Col 20 - Style/Blocks - Avoid using {...} for multi-line blocks.
• [ ] Style - Line 102, Col 38 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 118, Col 17 - Style/Blocks - Avoid using {...} for multi-line blocks.
• [ ] Style - Line 164, Col 18 - Style/Blocks - Avoid using {...} for multi-line blocks.
• [ ] Style - Line 174, Col 20 - Style/Blocks - Avoid using {...} for multi-line blocks.
• [ ] Style - Line 198, Col 20 - Style/Blocks - Avoid using {...} for multi-line blocks.
• [ ] Style - Line 214, Col 18 - Style/Blocks - Avoid using {...} for multi-line blocks.
• [ ] Style - Line 223, Col 18 - Style/Blocks - Avoid using {...} for multi-line blocks.

spec/rpm/requirement/gem_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/requirement/parser_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/spec/check_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/spec/comparison_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/spec/files_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/spec/gem_files_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.
• [ ] Style - Line 35, Col 26 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 36, Col 26 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 46, Col 26 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 47, Col 26 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 49, Col 26 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 50, Col 26 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 63, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 65, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 76, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.

spec/rpm/spec/gem_reference_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.
• [ ] Style - Line 15, Col 22 - Style/MultilineOperationIndentation - Use 2 (not 13) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 16, Col 22 - Style/MultilineOperationIndentation - Use 2 (not 13) spaces for indenting an expression spanning multiple lines.

spec/rpm/spec/gem_requirement_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/spec/parser_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/spec/requirements_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/spec/subpackages_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/spec/updater_spec.rb

• [ ] Style - Line 7, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.
• [ ] Style - Line 15, Col 34 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] Style - Line 26, Col 11 - Style/IndentationConsistency - Inconsistent indentation detected.
• [ ] Style - Line 40, Col 56 - Style/DotPosition - Place the . on the next line, together with the method name.
• [ ] Style - Line 41, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.

spec/targets/koji/builder_spec.rb

• [ ] Style - Line 16, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 22, Col 24 - Style/MultilineOperationIndentation - Use 2 (not 15) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 43, Col 11 - Style/Lambda - Use the new lambda literal syntax ->(params) {...}.

spec/targets/koji/rpc_spec.rb

• [ ] Style - Line 24, Col 54 - Style/WordArray - Use %w or %W for array of words.

spec/targets/koji/versions_spec.rb

• [ ] Style - Line 55, Col 63 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 68, Col 63 - Style/WordArray - Use %w or %W for array of words.

[coveralls]

Coverage increased (+1.85%) when pulling 6bdccb4b1c9a011d242e33b7fbbe4ea4af7ff27d on movitto:tests2 into 77f94a05d0924b64843bc9236a02a6363db32eaf on ManageIQ:master.

[coveralls]

Coverage increased (+1.85%) when pulling 6bdccb4b1c9a011d242e33b7fbbe4ea4af7ff27d on movitto:tests2 into 77f94a05d0924b64843bc9236a02a6363db32eaf on ManageIQ:master.