Additonal Test Enhancements

[movitto]

Continuing tests started in #128, this flushes out the tests for the classes / modules in the Polisher::RPM namespace

[coveralls]

Coverage increased (+2.06%) when pulling 896d830ac6b3884b7d4c82bc967a9597925cfe75 on movitto:test3 into 77f94a05d0924b64843bc9236a02a6363db32eaf on ManageIQ:master.

[jrafanie]

@movitto Failed test, can you review?

[miq-bot]

Checked commits https://github.com/movitto/polisher-1/commit/601dc48410120e07172ba698e46922cee47d1f3b .. https://github.com/movitto/polisher-1/commit/896d830ac6b3884b7d4c82bc967a9597925cfe75 with rubocop 0.27.1 28 files checked, 61 offenses detected

lib/polisher/rpm/patch.rb

• [ ] Style - Line 26, Col 1 - Style/EmptyLines - Extra blank line detected.

lib/polisher/rpm/spec/updater.rb

• [ ] Style - Line 25, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 26, Col 19 - Style/MultilineOperationIndentation - Use 2 (not 10) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 32, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 33, Col 19 - Style/MultilineOperationIndentation - Use 2 (not 10) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 154, Col 1 - Style/EmptyLines - Extra blank line detected.
• [ ] Style - Line 185, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for update_files_from is too high. [44.55/15]
• [ ] Style - Line 185, Col 7 - Metrics/CyclomaticComplexity - Cyclomatic complexity for update_files_from is too high. [7/6]
• [ ] Style - Line 185, Col 7 - Metrics/MethodLength - Method has too many lines. [27/25]
• [ ] Style - Line 185, Col 7 - Metrics/PerceivedComplexity - Perceived complexity for update_files_from is too high. [8/7]
• [ ] Style - Line 223, Col 42 - Style/SymbolProc - Pass &:rpmize as an argument to collect instead of a block.
• [ ] Style - Line 257, Col 32 - Style/MultilineOperationIndentation - Use 2 (not 23) spaces for indenting an expression spanning multiple lines.

spec/fixtures/gem_json.rb

• [ ] Style - Line 6, Col 16 - Style/SpaceAroundOperators - Surrounding space missing for operator '||='.
• [ ] Style - Line 40, Col 11 - Style/RedundantSelf - Redundant self detected.

spec/fixtures/local_gem.rb

• [ ] Style - Line 53, Col 11 - Style/RedundantSelf - Redundant self detected.

spec/fixtures/rpm_spec.rb

• [ ] Style - Line 29, Col 76 - Style/TrailingWhitespace - Trailing whitespace detected.
• [ ] Style - Line 82, Col 11 - Style/RedundantSelf - Redundant self detected.

spec/rpm/patch_spec.rb

• [ ] Style - Line 8, Col 8 - Style/ClassAndModuleChildren - Use nested module/class definitions instead of compact style.

spec/rpm/spec/gem_files_spec.rb

• [ ] Style - Line 107, Col 52 - Style/BracesAroundHashParameters - Redundant curly braces around a hash parameter.
• [ ] Style - Line 107, Col 80 - Style/WordArray - Use %w or %W for array of words.

spec/rpm/spec/gem_reference_spec.rb

• [ ] Style - Line 18, Col 22 - Style/MultilineOperationIndentation - Use 2 (not 13) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 29, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 31, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 31, Col 37 - Style/SpaceAroundOperators - Surrounding space missing for operator '-'.
• [ ] Style - Line 40, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 42, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 42, Col 41 - Style/SpaceAroundOperators - Surrounding space missing for operator '-'.

spec/rpm/spec/updater_spec.rb

• [ ] Style - Line 16, Col 33 - Style/TrailingWhitespace - Trailing whitespace detected.
• [ ] Style - Line 49, Col 20 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 56, Col 20 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 58, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 66, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 76, Col 15 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 78, Col 15 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 78, Col 39 - Style/SpaceAroundOperators - Surrounding space missing for operator '-'.
• [ ] Style - Line 91, Col 20 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 98, Col 20 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 100, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 108, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 118, Col 15 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 120, Col 15 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 120, Col 43 - Style/SpaceAroundOperators - Surrounding space missing for operator '-'.
• [ ] Style - Line 129, Col 55 - Style/TrailingWhitespace - Trailing whitespace detected.
• [ ] Style - Line 167, Col 68 - Style/TrailingWhitespace - Trailing whitespace detected.
• [ ] Style - Line 205, Col 75 - Style/TrailingWhitespace - Trailing whitespace detected.
• [ ] Style - Line 214, Col 65 - Style/TrailingWhitespace - Trailing whitespace detected.
• [ ] Style - Line 225, Col 1 - Style/TrailingWhitespace - Trailing whitespace detected.
• [ ] Style - Line 315, Col 17 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 322, Col 17 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 332, Col 19 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 333, Col 35 - Style/SpaceBeforeBlockBraces - Space missing to the left of {.
• [ ] Style - Line 360, Col 1 - Style/EmptyLines - Extra blank line detected.
• [ ] Style - Line 390, Col 20 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 392, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 393, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 401, Col 20 - Style/WordArray - Use %w or %W for array of words.
• [ ] Style - Line 403, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] Style - Line 404, Col 13 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.

spec/rpm/spec_spec.rb

• [ ] Style - Line 40, Col 17 - Style/Blocks - Avoid using {...} for multi-line blocks.

spec/support/coveralls.rb

• [ ] Warn - Line 9, Col 1 - Lint/HandleExceptions - Do not suppress exceptions.

spec/support/fixtures.rb

• [ ] Style - Line 6, Col 3 - Style/CommentAnnotation - Annotation keywords should be all upper case, followed by a colon and a space, then a note describing the problem.