Refactoring & Doc Enhancements

bin/git_gem_diff.rb

[ ] :red_circle: Warn - Line 15, Col 5 - Lint/UselessAssignment - Useless assignment to variable - conf.
[ ] :large_orange_diamond: - Line 15, Col 5 - Style/IndentationConsistency - Inconsistent indentation detected.

bin/git_gem_updater.rb

[ ] :red_circle: Warn - Line 20, Col 5 - Lint/UselessAssignment - Useless assignment to variable - conf.
[ ] :large_orange_diamond: - Line 20, Col 5 - Style/IndentationConsistency - Inconsistent indentation detected.

lib/polisher/cli/bin/check_ruby_spec.rb

[ ] :large_orange_diamond: - Line 30, Col 7 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.

lib/polisher/cli/bin/git_gem_diff.rb

[ ] :large_orange_diamond: - Line 12, Col 19 - Style/BracesAroundHashParameters - Redundant curly braces around a hash parameter.
[ ] :large_orange_diamond: - Line 12, Col 20 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
[ ] :large_orange_diamond: - Line 12, Col 32 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.

lib/polisher/cli/bin/git_gem_updater.rb

[ ] :large_orange_diamond: - Line 13, Col 3 - Metrics/ModuleLength - Module has too many lines. [107/100]
[ ] :large_orange_diamond: - Line 19, Col 19 - Style/BracesAroundHashParameters - Redundant curly braces around a hash parameter.
[ ] :large_orange_diamond: - Line 19, Col 20 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
[ ] :large_orange_diamond: - Line 21, Col 21 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
[ ] :large_orange_diamond: - Line 21, Col 29 - Style/ExtraSpacing - Unnecessary spacing detected.
[ ] :large_orange_diamond: - Line 21, Col 33 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
[ ] :large_orange_diamond: - Line 25, Col 54 - Style/SpaceInsideParens - Space inside parentheses detected.
[ ] :large_orange_diamond: - Line 29, Col 63 - Style/SpaceInsideParens - Space inside parentheses detected.
[ ] :large_orange_diamond: - Line 33, Col 108 - Style/SpaceInsideParens - Space inside parentheses detected.
[ ] :large_orange_diamond: - Line 73, Col 29 - Style/SpaceAroundEqualsInParameterDefault - Surrounding space missing in default value assignment.
[ ] :large_orange_diamond: - Line 105, Col 9 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
[ ] :large_orange_diamond: - Line 109, Col 7 - Style/RedundantBegin - Redundant begin block detected.

lib/polisher/cli/bin/ruby_rpm_spec_updater.rb

[ ] :large_orange_diamond: - Line 32, Col 14 - Style/ExtraSpacing - Unnecessary spacing detected.
[ ] :large_orange_diamond: - Line 32, Col 16 - Style/SpaceAroundOperators - Operator ||= should be surrounded with a single space.
[ ] :large_orange_diamond: - Line 32, Col 20 - Style/MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.

lib/polisher/cli/status.rb

[ ] :large_orange_diamond: - Line 50, Col 43 - Style/SpaceAroundEqualsInParameterDefault - Surrounding space missing in default value assignment.
[ ] :large_orange_diamond: - Line 54, Col 43 - Style/SpaceAroundEqualsInParameterDefault - Surrounding space missing in default value assignment.

lib/polisher/rpm/spec/comparison.rb

[ ] :small_blue_diamond: - Line 28, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for compare_upstream_deps is too high. [28.51/15]
[ ] :small_blue_diamond: - Line 50, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for compare_local_deps is too high. [29.44/15]

ManageIQ / polisher