Override all mkmf lookup methods to lookup binary gem deps

[movitto]

Provided a binary gem uses the standard mkmf lookup methods to verify dependencies the binary_gem_resolver utility should now be able to lookup all missing components using the native package system.

[miq-bot]

Checked commit https://github.com/movitto/polisher-1/commit/88bed1cf952d39b2344e799739f6f69de91920fd with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 2 files checked, 67 offenses detected

bin/binary_gem_resolver.rb

• [ ] :large_orange_diamond: - Line 21, Col 2 - Style/IndentationConsistency - Inconsistent indentation detected.

lib/polisher/cli/bin/binary_gem_resolver.rb

• [ ] :large_orange_diamond: - Line 27, Col 18 - Style/RegexpLiteral - Use %r around regular expression.
• [ ] :large_orange_diamond: - Line 54, Col 3 - Style/RedundantReturn - Redundant return detected.
• [ ] :large_orange_diamond: - Line 58, Col 17 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• [ ] :large_orange_diamond: - Line 60, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 60, Col 15 - Style/RegexpLiteral - Use %r around regular expression.
• [ ] :large_orange_diamond: - Line 61, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 62, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 63, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 63, Col 15 - Style/RegexpLiteral - Use %r around regular expression.
• [ ] :large_orange_diamond: - Line 64, Col 3 - Style/MultilineBlockChain - Avoid multi-line chains of blocks.
• [ ] :large_orange_diamond: - Line 70, Col 41 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• [ ] :large_orange_diamond: - Line 71, Col 16 - Style/PerlBackrefs - Avoid the use of Perl-style backrefs.
• [ ] :large_orange_diamond: - Line 84, Col 3 - Style/MultilineOperationIndentation - Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 85, Col 3 - Style/MultilineOperationIndentation - Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 85, Col 17 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• [ ] :large_orange_diamond: - Line 87, Col 5 - Style/MultilineOperationIndentation - Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 114, Col 16 - Style/SpaceAroundEqualsInParameterDefault - Surrounding space missing in default value assignment.
• [ ] :large_orange_diamond: - Line 116, Col 45 - Style/SpaceAroundOperators - Operator || should be surrounded with a single space.
• [ ] :large_orange_diamond: - Line 129, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 130, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 131, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 133, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 135, Col 1 - Style/Alias - Use alias_method instead of alias.
• [ ] :large_orange_diamond: - Line 136, Col 5 - Style/PredicateName - Rename have_library to library?.
• [ ] :large_orange_diamond: - Line 139, Col 27 - Style/ExtraSpacing - Unnecessary spacing detected.
• [ ] :large_orange_diamond: - Line 143, Col 1 - Style/Alias - Use alias_method instead of alias.
• [ ] :large_orange_diamond: - Line 152, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 153, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 154, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 158, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 160, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 161, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 162, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 164, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 166, Col 1 - Style/Alias - Use alias_method instead of alias.
• [ ] :large_orange_diamond: - Line 167, Col 5 - Style/PredicateName - Rename have_header to header?.
• [ ] :large_orange_diamond: - Line 174, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 176, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 177, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 178, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 180, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 182, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 183, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 184, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 185, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 187, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 189, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 190, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 191, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 192, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 194, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 196, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 197, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 198, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 199, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 201, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 203, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 204, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 205, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 206, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 208, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 210, Col 1 - Style/Alias - Use alias_method instead of alias.
• [ ] :large_orange_diamond: - Line 214, Col 28 - Style/ExtraSpacing - Unnecessary spacing detected.
• [ ] :large_orange_diamond: - Line 217, Col 1 - Style/TrailingBlankLines - 1 trailing blank lines detected.
• [ ] :small_blue_diamond: - Line 19, Col 3 - Style/DoubleNegation - Avoid the use of double negation (!!).
• [ ] :small_blue_diamond: - Line 114, Col 1 - Metrics/CyclomaticComplexity - Cyclomatic complexity for lookup is too high. [7/6]