Fixes & Updates to support new update_gems utility

[movitto]

Many various fixes and refactoring to extract generic components. Adds update_gems utility which traverses gem dependency tree in same manner as gems2update and runs same update as git_gem_updater

[miq-bot]

Checked commits https://github.com/movitto/polisher-1/compare/229aaf32ac4eab7332bd31bdf6e79f6737a28776~...fd0ceda0fce393577d4bf7b8b972f631af190e30 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 17 files checked, 50 offenses detected

bin/update_gems.rb

• [ ] :large_orange_diamond: - Line 16, Col 5 - Style/IndentationConsistency - Inconsistent indentation detected.
• [ ] :large_orange_diamond: - Line 24, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 26, Col 1 - Style/LeadingCommentSpace - Missing space after #.
• [ ] :large_orange_diamond: - Line 27, Col 1 - Style/LeadingCommentSpace - Missing space after #.

lib/polisher/cli/bin/gems2update.rb

• [ ] :red_circle: Warn - Line 52, Col 65 - Lint/UnusedBlockArgument - Unused block argument - resolved_dep. If it's necessary, use _ or _resolved_dep as an argument name to indicate that it won't be used.
• [ ] :large_orange_diamond: - Line 26, Col 21 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• [ ] :large_orange_diamond: - Line 27, Col 11 - Style/ExtraSpacing - Unnecessary spacing detected.
• [ ] :large_orange_diamond: - Line 53, Col 31 - Style/ClassCheck - Prefer Object#kind_of? over Object#is_a?.
• [ ] :small_blue_diamond: - Line 25, Col 1 - Metrics/AbcSize - Assignment Branch Condition size for check_missing is too high. [23.17/15]

lib/polisher/cli/bin/git_gem_updater.rb

• [ ] :large_orange_diamond: - Line 16, Col 11 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 17, Col 11 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 18, Col 11 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.

lib/polisher/cli/bin/missing_deps.rb

• [ ] :red_circle: Warn - Line 25, Col 55 - Lint/ShadowingOuterLocalVariable - Shadowing outer local variable - source.
• [ ] :red_circle: Warn - Line 25, Col 68 - Lint/UnusedBlockArgument - Unused block argument - resolved_dep. If it's necessary, use _ or _resolved_dep as an argument name to indicate that it won't be used.

lib/polisher/cli/bin/update_gems.rb

• [ ] :red_circle: Warn - Line 24, Col 30 - Lint/UnusedBlockArgument - Unused block argument - deps. If it's necessary, use _ or _deps as an argument name to indicate that it won't be used.
• [ ] :red_circle: Warn - Line 39, Col 55 - Lint/UnusedBlockArgument - Unused block argument - src. If it's necessary, use _ or _src as an argument name to indicate that it won't be used.
• [ ] :red_circle: Warn - Line 39, Col 65 - Lint/UnusedBlockArgument - Unused block argument - resolved_dep. If it's necessary, use _ or _resolved_dep as an argument name to indicate that it won't be used.
• [ ] :red_circle: Warn - Line 46, Col 21 - Lint/UnusedMethodArgument - Unused method argument - conf. If it's necessary, use _ or _conf as an argument name to indicate that it won't be used. You can also write as run_gems_update(*) if you want the method to accept any arguments but don't care about them.
• [ ] :large_orange_diamond: - Line 11, Col 7 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 12, Col 7 - Style/MultilineOperationIndentation - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 24, Col 21 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.

lib/polisher/cli/cross_ref.rb

• [ ] :large_orange_diamond: - Line 19, Col 14 - Style/ClassCheck - Prefer Object#kind_of? over Object#is_a?.
• [ ] :large_orange_diamond: - Line 51, Col 31 - Style/ExtraSpacing - Unnecessary spacing detected.
• [ ] :large_orange_diamond: - Line 51, Col 33 - Style/SpaceAroundOperators - Operator << should be surrounded with a single space.
• [ ] :large_orange_diamond: - Line 52, Col 27 - Style/ExtraSpacing - Unnecessary spacing detected.
• [ ] :large_orange_diamond: - Line 57, Col 32 - Style/SpaceAroundOperators - Operator ||= should be surrounded with a single space.
• [ ] :large_orange_diamond: - Line 59, Col 49 - Style/MultilineOperationIndentation - Align the operands of an expression in an assignment spanning multiple lines.
• [ ] :large_orange_diamond: - Line 59, Col 114 - Style/SpaceInsideBlockBraces - Space missing inside }.
• [ ] :small_blue_diamond: - Line 44, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for check_missing_dep is too high. [19.87/15]
• [ ] :small_blue_diamond: - Line 46, Col 121 - Metrics/LineLength - Line is too long. [124/120]

lib/polisher/cli/fedora.rb

• [ ] :large_orange_diamond: - Line 15, Col 63 - Style/SpaceInsideParens - Space inside parentheses detected.

lib/polisher/cli/paths.rb

• [ ] :large_orange_diamond: - Line 15, Col 8 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• [ ] :large_orange_diamond: - Line 15, Col 25 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• [ ] :large_orange_diamond: - Line 19, Col 108 - Style/SpaceInsideParens - Space inside parentheses detected.

lib/polisher/cli/sources.rb

• [ ] :large_orange_diamond: - Line 63, Col 7 - Style/DoubleNegation - Avoid the use of double negation (!!).

lib/polisher/cli/updater.rb

• [ ] :large_orange_diamond: - Line 11, Col 8 - Style/SpaceInsideHashLiteralBraces - Space inside { detected.
• [ ] :large_orange_diamond: - Line 13, Col 24 - Style/SpaceInsideHashLiteralBraces - Space inside } detected.
• [ ] :large_orange_diamond: - Line 17, Col 57 - Style/SpaceInsideParens - Space inside parentheses detected.
• [ ] :large_orange_diamond: - Line 27, Col 23 - Style/SpaceAroundOperators - Operator << should be surrounded with a single space.
• [ ] :large_orange_diamond: - Line 29, Col 23 - Style/SpaceAroundOperators - Operator << should be surrounded with a single space.
• [ ] :large_orangediamond: - Line 32, Col 9 - Style/AccessorMethodName - Do not prefix writer method names with `set`.
• [ ] :large_orange_diamond: - Line 36, Col 25 - Style/SpaceAroundEqualsInParameterDefault - Surrounding space missing in default value assignment.
• [ ] :large_orange_diamond: - Line 63, Col 9 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 71, Col 21 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :large_orange_diamond: - Line 73, Col 21 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :large_orange_diamond: - Line 86, Col 9 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 89, Col 7 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
• [ ] :large_orange_diamond: - Line 91, Col 7 - Style/RedundantBegin - Redundant begin block detected.
• [ ] :small_blue_diamond: - Line 62, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for update_gems is too high. [18.36/15]
• [ ] :small_blue_diamond: - Line 127, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for update_gem_deps is too high. [15.03/15]