Rpm spec conditionals

[movitto]

Begin adding support to parse & use spec conditionals in rpm subsystem

[coveralls]

Coverage decreased (-0.5%) to 94.246% when pulling 02867f9e40a1325d0d3995350a8bf1c891d5e619 on movitto:rpm_spec_conditionals into 8c19023c72573999c9dc53ec2e2a3eef11a9531e on ManageIQ:master.

[coveralls]

Coverage decreased (-0.5%) to 94.246% when pulling 639b1c774bc3fe7ed552faa6112687d0c5fc1bd6 on movitto:rpm_spec_conditionals into 8c19023c72573999c9dc53ec2e2a3eef11a9531e on ManageIQ:master.

[miq-bot]

Checked commits https://github.com/movitto/polisher-1/compare/5e055f74a268a951934509e36518875986653a6c~...639b1c774bc3fe7ed552faa6112687d0c5fc1bd6 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 9 files checked, 18 offenses detected

lib/polisher/rpm/condition.rb

• [ ] :large_orange_diamond: - Line 19, Col 11 - Style/PredicateName - Rename has_requires? to requires?.
• [ ] :large_orange_diamond: - Line 20, Col 43 - Style/SymbolProc - Pass &:has_requires? as an argument to any? instead of a block.
• [ ] :large_orange_diamond: - Line 25, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 26, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 29, Col 11 - Style/PredicateName - Rename has_build_requires? to build_requires?.
• [ ] :large_orange_diamond: - Line 30, Col 49 - Style/SymbolProc - Pass &:has_build_requires? as an argument to any? instead of a block.
• [ ] :large_orange_diamond: - Line 35, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 36, Col 9 - Style/MultilineOperationIndentation - Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
• [ ] :large_orange_diamond: - Line 40, Col 98 - Style/SpaceInsideBlockBraces - Space missing inside }.
• [ ] :large_orange_diamond: - Line 44, Col 110 - Style/SpaceInsideBlockBraces - Space missing inside }.

lib/polisher/rpm/spec.rb

• [ ] :large_orange_diamond: - Line 69, Col 9 - Style/MutableConstant - Freeze mutable objects assigned to constants.

lib/polisher/rpm/spec/parser.rb

• [ ] :large_orange_diamond: - Line 76, Col 1 - Style/EmptyLines - Extra blank line detected.

lib/polisher/rpm/spec/updater.rb

• [ ] :large_orange_diamond: - Line 52, Col 46 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• [ ] :large_orange_diamond: - Line 64, Col 46 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• [ ] :large_orange_diamond: - Line 142, Col 11 - Style/MultilineMethodCallIndentation - Align .select with .keys on line 141.
• [ ] :large_orange_diamond: - Line 143, Col 11 - Style/MultilineMethodCallIndentation - Align .collect with .keys on line 141.
• [ ] :large_orange_diamond: - Line 143, Col 20 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.

lib/polisher/util/core_ext.rb

• [ ] :large_orange_diamond: - Line 51, Col 5 - Style/MultilineOperationIndentation - Align the operands of an expression in an assignment spanning multiple lines.