Dialog User - stable validation, consistent refresh and initial load

himdel commented 5 years ago

This changes how dialog user does field init & validation:

server updates from inital load and from subsequent refreshes go through a initField function (which calls setupField), allowing for consistent data format transformations on load
- this requires that setupField be idempotent, adding a check to only transform JSON strings when in string form, and not do that again
- all validation is done on change, no longer also on blur (the blur validation would not propagate out because any saving is done on change)
dialog field no longer transforms values - previously we would validate multiselects as an array, then join the array to push to dialog user, then validate the same field, with the joined string instead of an array - any transformation needs to happen when saving
dateField & timeField are no longer a thing outside dialogField - on change, we save the value to default_value, so it can be validated and pushed outside like everything else; incorporates changes from https://github.com/ManageIQ/ui-components/pull/398
makes refresh code use the same path, and correctly call initField for new values
- (verified single field refresh goes through initField -> setupField -> DialogField.$onInit)
(later TODO - maybe setupField should not even be used by DialogField, always relying on initField)
(later TODO - we should only initField once, then setupField can just do straighforward server format to client format conversion)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1720245 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693294 Fixes #396 Closes #398

himdel commented 5 years ago

@eclarizio @romanblanco if you can, please review :) :eyes:

himdel commented 5 years ago

@miq-bot remove_label wip

Tests should be green too now

miq-bot commented 5 years ago

Checked commits https://github.com/himdel/ui-components/compare/4bbab11bf364dc1edff7c933c6418f99e892b0cb~...8889ee2a16cdf693fcd84e303061bd9a8e26008d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 0 files checked, 0 offenses detected Everything looks fine. :trophy:

simaishi commented 5 years ago

Hammer backport details:

$ git log -1
commit eb52db0dafec141001fe3779bdbdb47a6411c8f0
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Jul 8 14:09:44 2019 -0400

    Merge pull request #399 from himdel/validate-bz1720245

    Dialog User - stable validation, consistent refresh and initial load

    (cherry picked from commit 55f80b8dd014cb08b239d300ac698de6361cd128)

    https://bugzilla.redhat.com/show_bug.cgi?id=1727989
    https://bugzilla.redhat.com/show_bug.cgi?id=1727990

ManageIQ / ui-components

Dialog User - stable validation, consistent refresh and initial load #399