Remove code dealing with default value for Tag Control

ManageIQ / ui-components

Angular UI Components for ManageIQ

Apache License 2.0

16 stars 52 forks source link

Remove code dealing with default value for Tag Control #415

Closed romanblanco closed 5 years ago

romanblanco commented 5 years ago

reaction on https://github.com/ManageIQ/ui-components/pull/414#issuecomment-528266646

miq-bot commented 5 years ago

Checked commit https://github.com/romanblanco/ui-components/commit/665b2fe148b719a34e5bd480bb395f442625b766 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 0 files checked, 0 offenses detected Everything looks fine. :star:

himdel commented 5 years ago

I'm worried about what happens when you already select a value and have this field in the list of fields to refresh for another field.

And of dynamic default_value from automate, if that's possible for tag controls.

But it's possible none of those cases can really happen :).

romanblanco commented 5 years ago

and have this field in the list of fields to refresh for another field

Tag Control field can't be in a list of fields to refresh. It's not a refreshable field.

himdel commented 5 years ago

You're right, this should be fine. Merging :)

simaishi commented 4 years ago

Ivanchuk backport details:

$ git log -1
commit 8de4907701969db5f3a1a71aa9d594590ef673a9
Author: Martin Hradil <mhradil@redhat.com>
Date:   Mon Sep 23 13:51:04 2019 +0200

    Merge pull request #415 from romanblanco/tag_ctrl_default_value

    Remove code dealing with default value for Tag Control

    (cherry picked from commit c9c805517a99a8d32263a531a1ad7a951c7b3b12)