search

ManageIQ / ui-components

Angular UI Components for ManageIQ
Apache License 2.0
16 stars 52 forks source link

Remove conflicting toolbar styling #423

Closed epwinchell closed 5 years ago

epwinchell commented 5 years ago

This PR removes the original PF3 toolbar styling overrides that have been duplicated in the React repo (https://github.com/ManageIQ/react-ui-components/blob/master/src/toolbar/styles.scss#L21), preventing styling updates.

Issue: https://github.com/ManageIQ/manageiq-ui-classic/issues/6317

epwinchell commented 5 years ago

@miq-bot assign @himdel

miq-bot commented 5 years ago

Checked commit https://github.com/epwinchell/ui-components/commit/1dfbe865f7c7eec986fb965ff5aadc6dae34339c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 0 files checked, 0 offenses detected Everything looks fine. :+1:

epwinchell commented 5 years ago

@miq-bot add_label cleanup, formatting/styling, ivanchuk/no

miq-bot commented 5 years ago

@epwinchell Cannot apply the following label because they are not recognized: formatting/styling