search

ManageIQ / ui-components

Angular UI Components for ManageIQ
Apache License 2.0
16 stars 52 forks source link

Remove additional duplicate toolbar styling #424

Closed epwinchell closed 5 years ago

epwinchell commented 5 years ago

This PR removes additional PF3 toolbar styling overrides that have been duplicated in https://github.com/ManageIQ/react-ui-components

Follow-up to: https://github.com/ManageIQ/ui-components/pull/423 Issue: ManageIQ/manageiq-ui-classic#6317

epwinchell commented 5 years ago

@miq-bot add_label cleanup, ivanchuk/no

epwinchell commented 5 years ago

@miq-bot assign @himdel

epwinchell commented 5 years ago

@himdel This one can wait for the 1.3.3 release.

miq-bot commented 5 years ago

Checked commit https://github.com/epwinchell/ui-components/commit/24dee9fa89966340bbe2827010c95d950d1f0600 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 0 files checked, 0 offenses detected Everything looks fine. :star:

himdel commented 5 years ago

LGTM too :)

Just one thing, dropdown-kebab-pf is used for multiple things in manageiq - toolbars, notifications, charts kebab, something something containers...

Should it live in manageiq-ui-classic instead of toolbar code?

epwinchell commented 5 years ago

@himdel I'll look into it. Thanks.