search

ManageIQ / ui-components

Angular UI Components for ManageIQ
Apache License 2.0
16 stars 52 forks source link

DialogUser - update validator_type during field refresh #428

Closed himdel closed 5 years ago

himdel commented 5 years ago

when validator_type is set to 'regex' on load, the field will use the current validator_rule to validate, but if validator_type is changed only later in a method, the field never starts to validate.

Making sure both validator_rule and validator_type are respected during field refresh.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769960

gmcculloug commented 5 years ago

cc @tinaafitz

himdel commented 5 years ago

Updated the spec, thanks :)

miq-bot commented 5 years ago

Checked commits https://github.com/himdel/ui-components/compare/172297da2e91b9643368af568c9aae965e2ce2e6~...ae83007090a25b305ae2a780164d0e2f04abbae8 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 0 files checked, 0 offenses detected Everything looks fine. :cookie:

simaishi commented 5 years ago

Hammer backport details:

$ git log -1
commit 072a6946f36ced3c6b8620179ca113624210464d
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Mon Nov 18 16:04:23 2019 +0100

    Merge pull request #428 from himdel/bz1769960

    DialogUser - update validator_type during field refresh

    (cherry picked from commit e142ea34618eac221d4b139177b3853024a44f6b)

    https://bugzilla.redhat.com/show_bug.cgi?id=1773626
simaishi commented 4 years ago

Ivanchuk backport details:

$ git log -1
commit a88a4b0ba4179cd2ded443eb8a23043102dbeb63
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Mon Nov 18 16:04:23 2019 +0100

    Merge pull request #428 from himdel/bz1769960

    DialogUser - update validator_type during field refresh

    (cherry picked from commit e142ea34618eac221d4b139177b3853024a44f6b)

    https://bugzilla.redhat.com/show_bug.cgi?id=1773627