search

ManageIQ / ui-components

Angular UI Components for ManageIQ
Apache License 2.0
16 stars 52 forks source link

Dialog Editor - reset default_value when changing dropdown type, values, or between single and multiselect #437

Closed mzazrivec closed 4 years ago

mzazrivec commented 4 years ago
  1. Automation ➻ Automate ➻ Customization
  2. On "All Dialogs" ➻ Button Configuration ➻ Add new dialog
  3. Add a dropdownlist to the "new section"
  4. Edit the dropdownlist
  5. Leave the default 1,2,3 options
  6. Change value type to INTEGER, set the default to "One"
  7. Also set REQUIERED to Yes.
  8. Save and then Save the dialog
  9. Select dialog test5 and Configuration ➻ edit this dialog
  10. Edit the dropdownlist
  11. In Options, change MULTISELECT to Yes
  12. Save and then Save the dialog
  13. Observe the following error:

Screenshot from 2020-04-21 14-47-42

Closes https://github.com/ManageIQ/ui-components/pull/432

https://bugzilla.redhat.com/show_bug.cgi?id=1746211

The PR also updates node.js in travis to version 10 to fix travis failures.

miq-bot commented 4 years ago

Checked commits https://github.com/mzazrivec/ui-components/compare/c9c47999e72faa21ea2cf1b59a78408a8d9f3be8~...dd1ca9fe07c03ea970f83d876c0f1b0faeaa243f with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 1 file checked, 1 offense detected

**

himdel commented 4 years ago

Works for me, thanks :) Just that one extra console.log..

mzazrivec commented 4 years ago

Just that one extra console.log..

Removed, thank you.

simaishi commented 4 years ago

Ivanchuk backport details:

$ git log -1
commit 541f3e4eb5f0bd99fd920b3f4bee22c2deffb184
Author: Martin Hradil <mhradil@redhat.com>
Date:   Wed Apr 22 18:00:52 2020 +0200

    Merge pull request #437 from mzazrivec/bug-1746211

    Dialog Editor - reset default_value when changing dropdown type, values, or between single and multiselect

    (cherry picked from commit 2a03d66e50dabb9e9d04185fdb2b7881c1816237)

    https://bugzilla.redhat.com/show_bug.cgi?id=1746211
simaishi commented 4 years ago

Jansa backport details:

$ git log -1
commit a6c6ebbef2449048ad077987bb3af86570945f3c
Author: Martin Hradil <mhradil@redhat.com>
Date:   Wed Apr 22 18:00:52 2020 +0200

    Merge pull request #437 from mzazrivec/bug-1746211

    Dialog Editor - reset default_value when changing dropdown type, values, or between single and multiselect

    (cherry picked from commit 2a03d66e50dabb9e9d04185fdb2b7881c1816237)

    https://bugzilla.redhat.com/show_bug.cgi?id=1746211