miq-select: default liveSearchFocus to false

ManageIQ / ui-components

Angular UI Components for ManageIQ

Apache License 2.0

16 stars 52 forks source link

miq-select: default liveSearchFocus to false #438

Closed himdel closed 4 years ago

himdel commented 4 years ago

Prevent the select from focusing the search input on actions like selecting an option.

This makes it possible to unselect multiple items in a row, even when scolled down.

Fixes https://github.com/ManageIQ/manageiq-ui-classic/issues/7010

himdel commented 4 years ago

Gif of the issue:

Except this PR affects all angular forms in the UI (such as service dialogs).

miq-bot commented 4 years ago

Checked commit https://github.com/himdel/ui-components/commit/500b7eeb7ce46e7d1d4b88fc53c02ca2092289b5 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cake:

simaishi commented 4 years ago

Jansa backport details:

$ git log -1
commit 33378259be76e67771485c90ca7834e29924cb7a
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue May 19 08:52:40 2020 +0200

    Merge pull request #438 from himdel/livesearchfocus

    miq-select: default liveSearchFocus to false
    (cherry picked from commit b924793a54df3a006c15cf5614dca154f9e22ec8)