search

ManageIQ / ui-components

Angular UI Components for ManageIQ
Apache License 2.0
16 stars 52 forks source link

Correctly set null as default value for null and empty strings #451

Closed mzazrivec closed 4 years ago

mzazrivec commented 4 years ago
  1. create a service dialog with integer-type values, make sure 0 is among them
  2. make sure the data type is set to integer and that 0 is set as default value
  3. create a catalog item with the above service dialog
  4. order the catalog item and observe the form

before Screenshot from 2020-09-11 14-58-16

after Screenshot from 2020-09-11 14-56-34

Previously, 0 as default value would be incorrectly interpreted as no default value.

https://bugzilla.redhat.com/show_bug.cgi?id=1878103

miq-bot commented 4 years ago

Checked commit https://github.com/mzazrivec/ui-components/commit/60cd294e7aa4e63ffcbd5bf5e647b36c587f2c9e with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cookie:

simaishi commented 4 years ago

Jansa backport details:

$ git log -1
commit 54d99b8486ff7d4206a2f9a23a339a3e450c9de5
Author: Martin Hradil <mhradil@redhat.com>
Date:   Wed Sep 16 11:40:47 2020 +0000

    Merge pull request #451 from mzazrivec/correctly_set_default_values_for_null_and_empty_strings

    Correctly set null as default value for null and empty strings

    (cherry picked from commit c10011f0df9c51da0b8b953496dcfe1929f67478)
simaishi commented 4 years ago

Ivanchuk backport details:

$ git log -1
commit 10a0003ef0edcefa7658eeee4b1c68cc339d3c91
Author: Martin Hradil <mhradil@redhat.com>
Date:   Wed Sep 16 11:40:47 2020 +0000

    Merge pull request #451 from mzazrivec/correctly_set_default_values_for_null_and_empty_strings

    Correctly set null as default value for null and empty strings

    (cherry picked from commit c10011f0df9c51da0b8b953496dcfe1929f67478)

    https://bugzilla.redhat.com/show_bug.cgi?id=1878103