search

ManageIQ / ui-components

Angular UI Components for ManageIQ
Apache License 2.0
16 stars 52 forks source link

Add support message for regex #463

Closed akhilkr128 closed 2 years ago

akhilkr128 commented 2 years ago

issue

Screenshot 2022-03-28 at 5 06 24 PM Screenshot 2022-03-28 at 5 06 24 PM

Before merging this one, we need to merge this PR.

Dependent PRs

https://github.com/ManageIQ/manageiq/pull/21792 https://github.com/ManageIQ/manageiq-schema/pull/643

miq-bot commented 2 years ago

Checked commit https://github.com/akhilkr128/ui-components/commit/99500cf509a23ad7c160ff65ebd676d38e0e1887 with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :+1:

Fryguy commented 2 years ago

@kavyanekkalapu Are these components still used in the classic ui, or is it only for the service ui?

akhilkr128 commented 2 years ago

@Fryguy / @kavyanekkalapu I think ui-classic is taking the below components from ui-components. Please correct me if I am wrong.

Screenshot 2022-04-08 at 1 58 53 PM
kavyanekkalapu commented 2 years ago

@akhilkr128 We are using dialog editor ( files you edited ) . I don't think we are using few from above screenshot. i will check and delete those components in another pr.

kavyanekkalapu commented 2 years ago

cc @jeffibm please test

jeffibm commented 2 years ago

@kavyanekkalapu , tested ok the ui-components and its implementation in manageiq-ui-classic