search

ManageIQ / ui-components

Angular UI Components for ManageIQ
Apache License 2.0
16 stars 52 forks source link

Upgrade node version to 16 #464

Closed jeffibm closed 1 year ago

jeffibm commented 2 years ago

Upgrading package version node - from 14.0.0 to 16.0.0 npm from 6.0.0to8.0.0

Fixes - https://github.com/ManageIQ/manageiq-ui-classic/issues/8146

miq-bot commented 2 years ago

Checked commit https://github.com/jeffibm/ui-components/commit/8ecd024fc9ed6220d83a21ec2e6e480d7b00d0dd with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint 1 file checked, 1 offense detected

**

kbrock commented 2 years ago

@Fryguy I believe we were holding back on this so we would use the same version of node on all of the miq subprojects.

Now seems like the perfect time to upgrade this to node 16.

Do you see any issues?

Fryguy commented 2 years ago

Yes, upgrading this to nodejs 16 originall caused issues, but I can't recall what they were...I thought it failed specs, but apparently specs aren't running here?

EDIT: Opened https://github.com/ManageIQ/ui-components/issues/465

miq-bot commented 2 years ago

This pull request is not mergeable. Please rebase and repush.

miq-bot commented 1 year ago

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.