search

ManageIQ / ui-components

Angular UI Components for ManageIQ
Apache License 2.0
16 stars 52 forks source link

[WIP] Integrating Embedded Workflow options in Add Dialog- initial changes #469

Closed noopurAg closed 1 year ago

noopurAg commented 1 year ago

https://user-images.githubusercontent.com/52702093/233608528-877cd3bf-2a35-41e8-82c4-fb5ed7b9dfc0.mov

miq-bot commented 1 year ago

Checked commits https://github.com/noopurAg/ui-components/compare/125fff38476e91b2ff5f5499218a2bf49f41353b~...c3154f64dfcd9a9e6b3446ea8b6e7106ea0c1dba with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cookie:

miq-bot commented 1 year ago

Some comments on commits https://github.com/noopurAg/ui-components/compare/125fff38476e91b2ff5f5499218a2bf49f41353b~...c3154f64dfcd9a9e6b3446ea8b6e7106ea0c1dba

https://github.com/ManageIQ/ui-components/commit/c3154f64dfcd9a9e6b3446ea8b6e7106ea0c1dba

noopurAg commented 1 year ago
image image
Fryguy commented 1 year ago

The backend to store these values is completed, so this can move forward. cc @agrare @jeffibm

miq-bot commented 1 year ago

This pull request is not mergeable. Please rebase and repush.

Fryguy commented 1 year ago

@noopurAg Can this be closed since we merged https://github.com/ManageIQ/ui-components/pull/471?

noopurAg commented 1 year ago

yes , closing this.