search

ManagedKube / kubernetes-ops

Running Kubernetes in production
Apache License 2.0
297 stars 136 forks source link

Chore/Issue#449 - AWS terraform provider version updated for VPC module and GH workflow update #453

Closed yiskaneto closed 5 months ago

yiskaneto commented 10 months ago

PR Description

This resolves issue https://github.com/ManagedKube/kubernetes-ops/issues/449

Changes:

  1. AWS terraform provider version updated for VPC module

    With the retirement of EC2-Classic the enable_classiclink andenable_classiclink_dns_support attributes have been removed https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0 hence while trying to use the vpc module with the current configured provider version I get the following error:

      An argument named "enable_classiclink" is not expected here.

    Solution: Upgrade the terraform-aws-modules/vpc/aws version to 5.4.0 (latest version atm) along with the latest version of the aws terraform provider which atm is 5.31.0

  2. The terraform-pipeline-staging.yaml was updated so it can properly add the comments to the opened PR

yiskaneto commented 10 months ago

@sekka1 it seems I can't request review from you but mentioning you here so you're aware of it.

Cheers!