search

ManarOmari / Portoflio

0 stars 0 forks source link

merge all project worked with main #17

Closed ManarOmari closed 2 years ago

ManarOmari commented 2 years ago

Update index.html to fit template design 1 on Figma by adding work cards, multi-stories, and about me sections with the style.css file .

ManarOmari commented 2 years ago

Update index.html to fit template design 1 on Figma by adding work cards, multi-stories, and about me sections with the style.css file .

ManarOmari commented 2 years ago

I updated h1 to h2 . and still working a mobile version not desktop

tresorsawasawa commented 2 years ago

Hi @ManarOmari

Make sure when your project is under review to not add some changes which can disturb the review process. As You can see You added some changes with linters errors when I approved your project. Make sure to not repeat this the next time for the best practices. Kindly fix those linters errors.

ManarOmari commented 2 years ago

@.**** I merged the branch before doing checks .. I am going to do checks now and push by new pull request

On Sat, Jun 4, 2022 at 6:00 PM Tresor Sawasawa @.***> wrote:

Hi @ManarOmari https://github.com/ManarOmari

Make sure when your project is under review to not add some changes which can disturb the review process. As You can see You added some changes linters errors when I approved your project. Make sure to not repeat this the next time for the best practices. Kindly fix those linters errors

— Reply to this email directly, view it on GitHub https://github.com/ManarOmari/Portoflio/pull/17#issuecomment-1146629134, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIDTEI73G276IWMJVN722X3VNNVPZANCNFSM5XZNVSNA . You are receiving this because you were mentioned.Message ID: @.***>