Manashiku / MMDGenshin

Shader written for MMD to replicate the visual style of Genshin Impact
86 stars 19 forks source link

Outline Issue? #5

Closed TheNameIs-M closed 1 year ago

TheNameIs-M commented 1 year ago

I have been trying to figure this out for a while, and I am not sure if I am doing something wrong somewhere... The outlines for the model will not show up no matter what I do.

image image

I tried changing the Outline Width to "100.0f" and even that did not make it show up. Keeping the outlines I had set from PMX Editor got overwritten by the shader as well, which I figure is the function, but I thought to try it anyway just to make sure.

I will mention that I am using the aplaybox models, since I know this code was meant for models ripped straight from the game. I don't have the know-how to do that, though, so...

Anyway, yeah. I'm not sure what I'm doing wrong. I really hope this gets seen ;-; I'm too nervous to contact anyone directly. I don't want to bother anyone. Especially if I am doing something completely and obviously wrong.

TheNameIs-M commented 1 year ago

Ah, so I was replied to, but the comment is gone. Anyways, I apologize for being yet another user who is using an incompatible model (the aplaybox ones). You must get it often. ^^;

Well because I would like to have an answer for anyone looking at the same problem, the MMD Helper plug in for PMX Editor will make this work for the aplaybox models.

I had probably misread the step when setting up the model and thought it was only for if you are using MMM so I skipped it. It is the one about averaging normals to create edge lines.

Don't be freaked out by the edge lines around the eyes or mouth when the shader is loaded in, they just have to be rendered with different .fx files with outlines turned off. At least in my case, as without the shader and lightmaps, the parts look too bright on the model. The outline width line in the .fx works from there, so edit as needed!

Yasuharaa commented 1 year ago

Lol sorry my bad, I apogize. I hate aplaybox model. So if you want the outlines, just use the helper plugin and generate vertex color in 2nd UV.

Vertex color is the outline controller, so you have to set vertex color alpha/ vertex color.w to 1.0f or 0.5 is fine. (Default 0.519)

On Sat, Sep 2, 2023, 5:21 AM TheNameIsM @.***> wrote:

Ah, so I was replied to, but the comment is gone. Anyways, I apologize for being yet another user who is using an incompatible model (the aplaybox ones). You must get it often. ^^;

Well because I would like to have an answer for anyone looking at the same problem, the MMD Helper plug in for PMX Editor will make this work for the aplaybox models.

I had probably misread the step when setting up the model and thought it was only for if you are using MMM so I skipped it. It is the one about averaging normals to create edge lines.

Don't be freaked out by the edge lines around the eyes or mouth when the shader is loaded in, they just have to be rendered with different .fx files with outlines turned off. At least in my case, as without the shader and lightmaps, the parts look too bright on the model. The outline width line in the .fx works from there, so edit as needed!

— Reply to this email directly, view it on GitHub https://github.com/Manashiku/MMDGenshin/issues/5#issuecomment-1703383914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YB4LIZQEF6FRFZ7M4P53XYJNXBANCNFSM6AAAAAA4F4T3XY . You are receiving this because you commented.Message ID: @.***>

Yasuharaa commented 1 year ago

For the face area, you have to manually painting the vertex color. While painting set the vertex color.w to 0

On Sat, Sep 2, 2023, 5:34 AM 0053 Arief @.***> wrote:

Lol sorry my bad, I apogize. I hate aplaybox model. So if you want the outlines, just use the helper plugin and generate vertex color in 2nd UV.

Vertex color is the outline controller, so you have to set vertex color alpha/ vertex color.w to 1.0f or 0.5 is fine. (Default 0.519)

On Sat, Sep 2, 2023, 5:21 AM TheNameIsM @.***> wrote:

Ah, so I was replied to, but the comment is gone. Anyways, I apologize for being yet another user who is using an incompatible model (the aplaybox ones). You must get it often. ^^;

Well because I would like to have an answer for anyone looking at the same problem, the MMD Helper plug in for PMX Editor will make this work for the aplaybox models.

I had probably misread the step when setting up the model and thought it was only for if you are using MMM so I skipped it. It is the one about averaging normals to create edge lines.

Don't be freaked out by the edge lines around the eyes or mouth when the shader is loaded in, they just have to be rendered with different .fx files with outlines turned off. At least in my case, as without the shader and lightmaps, the parts look too bright on the model. The outline width line in the .fx works from there, so edit as needed!

— Reply to this email directly, view it on GitHub https://github.com/Manashiku/MMDGenshin/issues/5#issuecomment-1703383914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2YB4LIZQEF6FRFZ7M4P53XYJNXBANCNFSM6AAAAAA4F4T3XY . You are receiving this because you commented.Message ID: @.***>

TheNameIs-M commented 1 year ago

No worries, no worries. I had assumed many people have asked you about the aplaybox models not working very well or easily despite it already being said that the shader is meant for ripped models, so I can imagine that it gets annoying. If it helps — and, of course, if you would be okay with it — I might make a tutorial for the 1.1.6 version for those models since it is still somewhat compatible, just more difficult, and I have seemed to figure out how to apply it to them well enough. That way, there will be less confusion for people asking about the aplaybox models and you won't have to answer them repetitively

Thank you very much for answering even when it is probably very tiring and annoying to.

On Fri, Sep 1, 2023 at 3:37 PM Yasuharaa @.***> wrote:

For the face area, you have to manually painting the vertex color. While painting set the vertex color.w to 0

On Sat, Sep 2, 2023, 5:34 AM 0053 Arief @.***> wrote:

Lol sorry my bad, I apogize. I hate aplaybox model. So if you want the outlines, just use the helper plugin and generate vertex color in 2nd UV.

Vertex color is the outline controller, so you have to set vertex color alpha/ vertex color.w to 1.0f or 0.5 is fine. (Default 0.519)

On Sat, Sep 2, 2023, 5:21 AM TheNameIsM @.***> wrote:

Ah, so I was replied to, but the comment is gone. Anyways, I apologize for being yet another user who is using an incompatible model (the aplaybox ones). You must get it often. ^^;

Well because I would like to have an answer for anyone looking at the same problem, the MMD Helper plug in for PMX Editor will make this work for the aplaybox models.

I had probably misread the step when setting up the model and thought it was only for if you are using MMM so I skipped it. It is the one about averaging normals to create edge lines.

Don't be freaked out by the edge lines around the eyes or mouth when the shader is loaded in, they just have to be rendered with different .fx files with outlines turned off. At least in my case, as without the shader and lightmaps, the parts look too bright on the model. The outline width line in the .fx works from there, so edit as needed!

— Reply to this email directly, view it on GitHub < https://github.com/Manashiku/MMDGenshin/issues/5#issuecomment-1703383914>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AT2YB4LIZQEF6FRFZ7M4P53XYJNXBANCNFSM6AAAAAA4F4T3XY>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Manashiku/MMDGenshin/issues/5#issuecomment-1703394422, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCINFAOYH4I3SNIBPGPGUKLXYJPQ3ANCNFSM6AAAAAA4F4T3XY . You are receiving this because you modified the open/close state.Message ID: @.***>