Mandelliant / nextbook-django

Nextbook - Django based reading assistant
MIT License
1 stars 5 forks source link

Design and develop tests #57

Open Mandelliant opened 6 years ago

fabrv commented 6 years ago

I'll take it but could you be more descriptive? What functions do you want to test? Do you want CI or just python unittests? Thanks :))

Mandelliant commented 6 years ago

@fabrv Thanks! I haven't really spent much time learning about proper testing but I believe I just want python unit tests. A future project is to implement Travis CI. Happy to answer any questions I can

fabrv commented 6 years ago

@Mandelliant sorry for not answering . I will do the tests tomorrow 👍, I've been busy lately. Whenever you want CI just add the issue and tag me, I'll be happy to help you with it 🙌.

Mandelliant commented 6 years ago

@fabrv awesome, thank you. No rush, but make sure you open the PR before October ends so it can count for you for Hacktoberfest

fabrv commented 6 years ago

@Mandelliant sorry my dude, I quit ☹. I am unable to install the dependencies for your project, many of the dependencies on your requirements.txt have versions that are not in the Python Package Index, and I'm definitely not going to track 172 python packages individually.

Maybe I'm doing something wrong, maybe there's another way to install all those packages. If I am, it'll be great to have an installation/running guide in the README.md.

Mandelliant commented 6 years ago

@fabrv no worries! I'm using this project as a way to learn best open source practices, I've only just added a requirements.txt- I know it's a bit of a mess (I didn't build this in a virtual env so my dependencies are super weird). Honestly, flagging that the requirements need to be worked on and suggesting writing a 'getting started' guide are probably more helpful to me in the long run.

I'll update you when I work through this. Any input would be greatly appreciated!

Mandelliant commented 6 years ago

@fabrv I've updated most of the requirements (issue #69 for more comments)