search

ManderaGeneral / generalimport

Handle all your optional dependencies with a single call!
https://pypi.org/project/generalimport/
Apache License 2.0
16 stars 1 forks source link

`TypeError: catching classes that do not inherit from BaseException is not allowed` #41

Open ZanSara opened 1 year ago

ZanSara commented 1 year ago

Since release 0.5.0, MissingOptionalDependency is no more an Exception, which breaks all usages such as:

try:
    import hello
except MissingOptionalDependency as e:
    ....

as they now raise:

TypeError: catching classes that do not inherit from BaseException is not allowed

I don't want to sound pushy, but this makes 0.5.0 a big breaking release and I'll downgrade to 0.3.1 until the issue is resolved or the intentions of this change are at least clarified, so that I can use the library properly.

As an aside, when you introduce "dangerous" changes, please do so in a PR, so in case of trouble I can track back what was happening, why and how should I adapt my code. Without any documentation to refer to or release notes or anything of this sort, I have no idea why the change was made and what to do now that my project is broken :sweat_smile:

Mandera commented 1 year ago

Oh wow, I'm sorry about this, definitely a mistake on my part and I appreciate your feedback! I'm working on improving these lacking areas

I'm releasing a hotfix 0.5.1 as a temporary measure for other users