Closed Mandera closed 1 year ago
Ran into this because jsdom
wasn't installed when I tried to run jest
for genvector
Neither of them is good. Their entry point to metadata should probably be in read_hook_post
. And they should be defined in a proper meta-config file eventually. For now probably just hardcode it there.
Moved necessities to packager deps https://github.com/ManderaGeneral/generalpackager/commit/903449e9194c6d5295b5dfb684b0969487e5feb5 was a success!
It doesn't make sense to unify the deps for different targets as they work differently and for a target such as django it might need to define both.
Remove ability of pip install name[option]
because node doesn't have that.
Then when defining deps you could write something like "python:generallibrary". If not defined it would default to target.
This would scale better with additional targets
This issue didn't go the way I thought but this is good!
read_hook_post
from metadata.json
Python's is located in workflow.py
Node's is located in metadata.json