Make Targets, Targets Literal, and default target DRY

[Mandera]

Currently it's a coupled mess, would be good to clean up

class Metadata(ConfigFile):
    target: Literal["python", "node", "django", "exe"] = "python"

class File:
    """ Instantiated if its owner is. """
    target = Targets.python  # Should probably default to None, and then I put python on most files

    @property
    def target(self):
        if self._target is not Ellipsis:
            return self._target
        else:
            if self.localrepo.metadata_exists():
                return self.localrepo.metadata.target
            else:
                return self.Targets.python

_TARGETS = Literal["python", "node", "django", "exe"]  # This is coupled to generalpackager.api.localrepo.base.targets.Targets, not ideal

class Targets(DataClass):
    python = "python"
    node = "node"
    django = "django"
    exe = "exe"

[Mandera]

Might need to prioritize this. Trying to set default target to Python now and it's proving difficult.

• Ideally it should traverse down: Packager.target returns LocalRepo.target returns Metadata.target.
• The issue is that LocalRepo doesn't know which Metadata to return because it needs the target - Circular dependency.
  • If it would do an initial check with non-target localrepo + metadata then those would get cached
  • Could clear cache if it does find another target or something, but seems unnecessarily complex
  • If set target and found target mismatch it should error, but if target is unset it shouldn't
    • How would it detect set target if I'm making it default to python though
  • Could do an initial check inside .localrepo and .metadata to return the correct cache straight away
• It should also take Packager's init target into account.
• LocalRepo currently has no target parameter even

Right now it actually traverses the opposite way:

• Packager.localrepo will use Packager's target LocalRepo(name=self.name, path=self.path).targetted(target=self._target)
• LocalRepo.metadata uses LocalRepo's target self._cls_metadata(path=self.get_metadata_path())

Making Packager's instantiating read Metadata straight away would solve everything

• Is it really that slow?
• I vaguely remember that I wanted to be able to instantiate tons of these when checking external dependencies and such, so might not be the best idea

Times in microseconds - 431% time taken when exists and 271% when doesn't exist

Name | Exists | Didnt Exists -- | -- | -- Read metadata | 1640 | 1030 No read | 380 | 376 Update 2023-03-15 | 185 | 185

python -m timeit -s "from generalpackager import Packager" "Packager('generallibrary')"

[Mandera]

• No more unset targets
• Initializing _SharedTarget will only store its target in self._target
• .target is a cached property that will return in order _target, metadata.json, or default (python)
• Packager.localrepo will instantiate with Packager's target - Since it uses primarily _target this will be instant
• LocalRepo.metadata will use _cls_metadata which is tied to its targetted class

[Mandera]

Not a huge fan of how you have to instantiate LocalRepo_Node and Python. I want a unified way for the user to instantiate it. Probably a localrepo function Why is it only LocalRepo that has this issue? Package hosts have GitHub, PyPI and NPM. Doesn't really matter, the issue is that I wanted to be able to instantiate LocalRepo on a random local repo to get info about it