Broken module names for editable installs

[Mandera]

Getting weird names from get_installed_modules_names() such as __editable___generalpackager_0_5_7_finder for every editable install

Seems related to external

• https://github.com/pypa/setuptools/issues/3548

That's also mentioning the previous issue I had in workflow

• https://github.com/ManderaGeneral/generalpackager/issues/77#issuecomment-1518501905

[Mandera]

Wasn't happening at first in my local windows env, I then:

• Updated pip from 23.0.1 to 23.1
• Ran pip install -e . in generalpackager repo (Just to refresh)
• Tada - We now have __editable___generalpackager_0_5_7_finder being yielded by get_installed_modules_names()....

[Mandera]

This is a great showcase for why

• https://github.com/ManderaGeneral/generalpackager/issues/55

is needed

[Mandera]

• Upgraded setuptools from 65.5 to 67.7.1 (latest)
• Did not re-install generalpackager
• get_installed_modules_names yielded both generalpackager and __editable___generalpackager_0_5_7_finder
• Not sure if 65.5 yielded both so installed that again
• Ok they are both being yielded now (Cannot be certain it was the same before though)
• Back to latest version
• Same result
• Re installing generalpackager as editable
• The weird one is gone!! Only generalpackager there

Now the question is how do we temporarily ensure we don't use the bad version in the workflow? Used to have a necessities install step

• https://github.com/ManderaGeneral/generalpackager/commit/903449e9194c6d5295b5dfb684b0969487e5feb5
• https://github.com/ManderaGeneral/generalpackager/commit/8b656d5ba7624b1a17fad63cf57420c21cce0ea3

but that's now moved to a generalpackager dependency. Now the issue with that is that we need the proper setuptools before we install generalpackager

Updating to actions/setup-python@v4 from v2 might solve it

[Mandera]

Didn't fix it. Version 56.0.0 is being used. I think this might be defined by the Python distribution which it's usually installed with, doesn't really matter though.

Let's re-instate the installing of necessities step

[Mandera]

Seems to work!