86 ci with GitHub actions

ManderaGeneral / generalpackager

Tools to interface GitHub, PyPI, NPM and local modules / repos. Used for generating files to keep projects dry and synced. Tailored for ManderaGeneral for now.

https://pypi.org/project/generalpackager/

Apache License 2.0

0 stars 0 forks source link

86 ci with GitHub actions #87

Closed Mandera closed 1 year ago

Mandera commented 1 year ago

Had the first success with off-branch actions! https://github.com/ManderaGeneral/generalpackager/commit/1833d9276bedfbcaeedeef5feffca4c7ae853a39

Opening this PR as a learning experience for how it interfaces with the linked issue, also want to learn how to resolve merge conflicts

Mandera commented 1 year ago

Cool!

The branch was created through the issue so when the PR was opened it linked itself to the issue as closing
No workflow was triggered by PR, and the previous passed check for the latest commit was being displayed
There was a merge conflict for one file which I easily resolved in the browser, committing that caused a workflow trigger as expected!

Mandera commented 1 year ago

Chose to merge as rebase which triggered main workflow on master! Makes sense It also closed the issue!

Since I had commits in master when merging and I chose to rebase - The top commit became an unrelated https://github.com/ManderaGeneral/generalpackager/commit/34d1fe6083e189c2ace46de645723e180c3a3514

I think merging earlier would solve that