search

Manechat / izzy-moonbot

Replacement admin bot for Manechat
https://manechat.net
MIT License
5 stars 4 forks source link

Quote(s) -> pluralized properly #531

Closed MrOnosa closed 10 months ago

MrOnosa commented 10 months ago

It's a pet-peeve of mine.

MrOnosa commented 10 months ago

That's what I get for trying to program on my cell phone.

Ixrec commented 10 months ago

For what it's worth, if we want to be fancy about plural handling, what we'd really want is a little helper method like pluralize(number, "thing", "things"). It may be a trivial method, but over all the "(s)"s in a codebase like this (or in the one at my day job which does have such a helper) having a standard name for it and slightly less logic at the string interpolation site adds up to a significant benefit.

MrOnosa commented 10 months ago

And that's what I get for not just forking the project because it was working locally but I forgot to update all the files using the GitHub editor.

Noted on using pluralize. Were you thinking of a full library, like Pluralize.NET, or just a simple helper method?

Ixrec commented 10 months ago

Oh I just meant a simple helper method for us. I don't think Izzy's usage of plural words is nearly advanced or dynamic enough to benefit from what Pluralize.NET is doing.

ParaSwarm commented 10 months ago

@MrOnosa you're a peach and a warrior of light