Check for Windows OS functionality and errors

Maneesh3 / RedditStuffDownloader

Download any subreddit posts/media/content - with comments

GNU General Public License v3.0

7 stars 1 forks source link

Check for Windows OS functionality and errors #1

Open Maneesh3 opened 4 years ago

Maneesh3 commented 4 years ago

Check for Windows OS functionality and errors, as the main development is done in Mac OS, could not have a chance to check in Windows OS machine.

[ ] FFMPEG interaction should give an error if not present, also working without it ??? (must check this)
[x] dependencies (from requirements.txt) Working
[ ] text colors are not working in windows, replace with '' - the color code

Maneesh3 commented 4 years ago

made little changes in commit 363fa5a60b5498ba57e9329be14fa3454bdb01e9 , but major bugs found

Maneesh3 commented 4 years ago

found some odd behavior for FFMPEG module, as mentioned in main issue above, it is working ? might have been a mistake -- line 445

if(exten != 'NO_AUDIO'):
    os.system('ffmpeg -i '+ file_name_v+' -i '+file_name_a+' -c:v copy -c:a aac -strict experimental '+file_name)
    os.remove(file_name_v)
    os.remove(file_name_a)
else:
    os.rename(file_name_v,file_name)

Maneesh3 commented 4 years ago

found some odd behavior for FFMPEG module, as mentioned in main issue above, it is working ? might have been a mistake -- line 445
if(exten != 'NO_AUDIO'):
    os.system('ffmpeg -i '+ file_name_v+' -i '+file_name_a+' -c:v copy -c:a aac -strict experimental '+file_name)
    os.remove(file_name_v)
    os.remove(file_name_a)
else:
    os.rename(file_name_v,file_name)

change in line

https://github.com/Maneesh3/RedditStuffDownloader/blob/252d9132d476cb8621a4e8eb7093ce3012452973/Reddit-Stuff-Downloader/reddit-dwn.py#L448

in commit b9622e367fe443a2be8b82f58fd89864bb892e60 Changed the reddit audio URL