search

ManeraKai / simplytranslate_mobile

Privacy friendly frontend to Google Translate
https://manerakai.github.io/simplytranslate_mobile/
GNU General Public License v3.0
173 stars 15 forks source link

Smartphone rotation #130

Closed Valdnet closed 3 years ago

Valdnet commented 3 years ago

Steps:

  1. Launch the application.
  2. Tap on the text edit window (keyboard pop out).
  3. Rotate the smartphone to a horizontal position.
  4. Rotate the smartphone to an vertical position.

The application window is shifted up. The windows for changing languages are not visible.

obraz

The application window should return to its previous state. To change the language of the translations, the user has to move them down.

ManeraKai commented 3 years ago

Problem is this will affect the saved scrolled position. We'll se what will happen: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1328888130

Valdnet commented 3 years ago

The window still does not return to its previous position after being rotated with the keyboard displayed.

obraz

After hiding the keyboard, the language switching windows are not fully visible.

obraz

ManeraKai commented 3 years ago

Problem is that this is the regular TextField focus behavior. Changing it may mislead the user if he was scrolled to a specific position then rotated the phone.

Valdnet commented 3 years ago

Well. We are returning as it was before. It worked better 😉.

ManeraKai commented 3 years ago

I'll revert the commit then 👍

ManeraKai commented 3 years ago

Reverted it.