search

ManeraKai / simplytranslate_mobile

Privacy friendly frontend to Google Translate
https://manerakai.github.io/simplytranslate_mobile/
GNU General Public License v3.0
173 stars 15 forks source link

UI in wrong language #131

Closed anaskaejdar closed 3 years ago

anaskaejdar commented 3 years ago

I have my phone in persian language, so when I opened simplytranslate, it automatically put UI in arabic. I went to settings, and I think I changed the proper setting to persian "الفارسیه", but the UI is still in arabic despite that.

ManeraKai commented 3 years ago

That issue has happened in an old version of the app: #115 The version that you have is archived and you won't find it in F-Droid anymore but in archives. This version doesn't have the issue: https://f-droid.org/en/packages/com.simplytranslate_mobile/

Sitavi commented 3 years ago

The issue is still there on the new package :/

anaskaejdar commented 3 years ago

Yes, I concur, it's there on the new package. I only found simplytranslate today on fdroid.

ManeraKai commented 3 years ago

Really sorry for that. I hope this version works: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1332291184

ManeraKai commented 3 years ago

Note This version has some issues with the fallback language. I'm working on it but will work for Persian scenario for the mean time.

ManeraKai commented 3 years ago

Now if it finds a translation specific to a country e.g en-US, it will use it. Else if it finds just the language translation without country support e.g: en, it will use it. Else if it didn't find neither the country code nor the language code, it will go to the next language in the system, e.g [ar, en]. Else if it didn't find neither the contry nor the language code in any of the system's language list, it will fallback to en.

ManeraKai commented 3 years ago

For testing it: https://github.com/ManeraKai/simplytranslate_mobile/actions/runs/1332478004

Valdnet commented 3 years ago

Else if it didn't find neither the country code nor the language code, it will go to the next language in the system, e.g [ar, en] .

Is this the correct solution to the issue?

ManeraKai commented 3 years ago

Yes, Users add multiple languages for fallbacks. If he understands Turkish before English, he will have it this way: [ar, tr]. Now if there isn't an Arabic translation. It will fallback to Turkish instead of English.

Valdnet commented 3 years ago

I checked for European languages (switchable languages that I know more or less so as not to get lost 😁) it works fine. I invite other users to test in their region 😉.

Valdnet commented 3 years ago

We close the issue and release a new version 1.1.2?

ManeraKai commented 3 years ago

Yeah why not.